1.31.0 (cherry-pick release) #3865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
set-recommended
bwilkerson
approved these changes
Nov 29, 2022
#3862) * silence prefer_equal_for_default_values on >= 2.19 * >= * test fix * ++ * --
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Nov 30, 2022
Cherry-picks update of `prefer_equal_for_default_values` to be a no-op in SDKs `>=2.19`. See: dart-lang/linter#3865 Change-Id: I2669f0279a0913bc8b3c5b0501a9869608883a14 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/272543 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Phil Quitslund <pquitslund@google.com>
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Dec 12, 2022
* updates `unrelated_type_equality_checks` for `pkg:fixnum` restructuring * updates `prefer_equal_for_default_values` to not report for SDKs >=2.19, where this lint is now an analyzer diagnostic. (Note that these changes landed *before* the release cut-off. 😬) Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/274481 Fixes: https://github.com/dart/sdk/issues/56781234 --- pull `unrelated_type_equality_checks` fix See: dart-lang/linter#3868 (This should also unblock the fixnum internal roll.) Change-Id: I9af710b075c6280ee55153c559f91ac6a0b21f3d linter 1.31.0 Cherry-picks update of `prefer_equal_for_default_values` to be a no-op in SDKs `>=2.19`. See: dart-lang/linter#3865 Change-Id: I2669f0279a0913bc8b3c5b0501a9869608883a14 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274481 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Phil Quitslund <pquitslund@google.com>
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Aug 23, 2023
1.31.0 (cherry-pick release)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.31.0
prefer_equal_for_default_valuesto not report for SDKs>=2.19,where this lint is now an analyzer diagnostic.
Closes: #3864.
/cc @bwilkerson @srawlins @parlough