Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GitLab flavored fenced blockquote #403

Merged
merged 2 commits into from
Apr 1, 2022
Merged

Support GitLab flavored fenced blockquote #403

merged 2 commits into from
Apr 1, 2022

Conversation

chenzhiguang
Copy link
Contributor

Fixes: #359

How to use

const text = '>>>\nHello\n\nWorld!\n>>>';

final result = markdownToHtml(text, blockSyntaxes: [
  const FencedBlockquoteSyntax(),
]);

Copy link
Member

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding some tests in test/extensions/? The specification only has one:

https://docs.gitlab.com/ee/user/markdown.html#multiline-blockquote

I can't think of any interesting examples offhand.

Copy link
Member

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@srawlins srawlins merged commit f58890b into dart-lang:master Apr 1, 2022
@chenzhiguang chenzhiguang deleted the Support-GitLab-flavored-fenced-blockquote branch April 2, 2022 11:23
roubachof pushed a commit to roubachof/markdown that referenced this pull request Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for GitLab-style multiline blockquote
2 participants