Add types to more parameters #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Find parameters that are implicitly `dynamic` and add a static type of either `Object?` or in some cases where a non-null value was clearly required `Object`. There may be missed cases where a non-null value is required. Add `as dynamic` casts back in places where we were already relying on dynamic calls as required to pass static analysis. This has the added benefit of making those dangerous calls more obvious.
jakemac53
approved these changes
Dec 16, 2020
|
Isn't there a lint for this? |
|
Implicit dynamic in analysis options or something? |
Yes there is an analyzer option, not lint. It impacts too much other stuff so I haven't emailed it but that is how I found these. |
natebosch
added a commit
that referenced
this pull request
Dec 28, 2020
This argument had been implicitly dynamic. #162 made it `Object?` which can cause analysis errors that are otherwise hidden due to implicit casts. Any classes which implement `Matcher` and override `match` could omit the argument type, which mean to inherit from the parent. When that became `Object?` the cast to some other type which could have been implicit coming from `dynamic` must now be explicit.
natebosch
added a commit
that referenced
this pull request
Dec 29, 2020
This argument had been implicitly dynamic. #162 made it `Object?` which can cause analysis errors that are otherwise hidden due to implicit casts. Any classes which implement `Matcher` and override `match` could omit the argument type, which mean to inherit from the parent. When that became `Object?` the cast to some other type which could have been implicit coming from `dynamic` must now be explicit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Find parameters that are implicitly
dynamicand add a static type ofeither
Object?or in some cases where a non-null value was clearlyrequired
Object. There may be missed cases where a non-null value isrequired.
Add
as dynamiccasts back in places where we were already relying ondynamic calls as required to pass static analysis. This has the added
benefit of making those dangerous calls more obvious.