Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reverted min dart sdk to 2.12 #204

Closed
wants to merge 1 commit into from
Closed

Conversation

bsutton
Copy link

@bsutton bsutton commented Jan 4, 2023

This PR reverts matcher to a min dart-sdk of 2.12 as per issue #203.

There is however a problem with the dependencies which doesn't make sense to me.

The test related packages all use a version of 'any'. I assume this is to make matcher compatible with all versions of the test related packages (even though my understanding is that you should never publish with any?).

The problem is with the test_api override.

I don't understand what the override is doing as test_api already is declared as any. However it clearly is doing something as without it version solving fails.

The problem is that when we have the test_api override `pub' selects the lastest version of test_api (0.4.17) which has a minimum sdk constraint of 2.17.
I don't understand why pub is selecting 0.4.17 given that I'm running dart 2.12. My understanding is that the fact that I'm running 2.12 should have excluded 0.4.17 from being selected and instead a dart 2.12 compatible version of test_api should have been chosen.

If I change the override to a dart 2.12 compatible version of test_api all of the unit tests succeed.

The unit tests also succeed for dart 3.x using the test_api override with any.

@devoncarew
Copy link
Member

Thanks for the PR! We'll wait for a resolution to #203 before reviewing it.

@natebosch
Copy link
Member

Closing since we're rolling forward with the current SDK dep.

@natebosch natebosch closed this Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants