Change wrapMatcher to avoid relying on fuzzy arrows #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevmoo
approved these changes
Aug 30, 2017
|
Thanks! Will internal versions get updated automatically, or do I need to initiate something? |
|
Need to publish this externally, first. I can help you with that... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The predicate case in wrapMatcher is essentially relying on a now deprecated feature of strong mode that treated
dynamicasbottomwhen used in a function argument position. This feature is being deprecated and removed in Dart 2.0 (more context here dart-lang/sdk#29630 ).This adds code to explicitly handle the cases previously handled using fuzzy arrows.