Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audio: aac, mp3, ogg, webm #57

Merged
merged 9 commits into from Nov 15, 2022
Merged

audio: aac, mp3, ogg, webm #57

merged 9 commits into from Nov 15, 2022

Conversation

cedvdb
Copy link
Contributor

@cedvdb cedvdb commented Oct 20, 2021

audio: aac, mp3, opus, webm.

I added the unit test although they are borderline useless

@google-cla google-cla bot added the cla: yes label Oct 20, 2021
@cedvdb cedvdb changed the title audio: aac, mp3, ogg audio: aac, mp3, ogg, webm Oct 20, 2021
@kevmoo
Copy link
Member

kevmoo commented Feb 10, 2022

Rebase?

Move entries to current version.
Add entry for changing audio/x-aac.
Fix entry for audio/mpeg to match exact mime type.
@@ -10,7 +10,7 @@ const Map<String, String> defaultExtensionMap = <String, String>{
'3gp': 'video/3gpp',
'7z': 'application/x-7z-compressed',
'aab': 'application/x-authorware-bin',
'aac': 'audio/x-aac',
'aac': 'audio/aac',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reference for this change?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lib/src/magic_number.dart Outdated Show resolved Hide resolved
@natebosch natebosch merged commit 642c9ce into dart-lang:master Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants