-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make verifyInOrder fail given non-mock-calls. #376
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds a test for verify failing when given a non-mock call.
srawlins
approved these changes
Mar 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
srawlins
added a commit
that referenced
this pull request
Apr 7, 2021
srawlins
added a commit
that referenced
this pull request
Apr 12, 2021
srawlins
added a commit
that referenced
this pull request
Apr 12, 2021
*** Reason for rollback *** Broke https://test.corp.google.com/ui#cl=365134781&flags=CAMQBQ==&id=OCL:365134781:BASE:367271161:1617822936639:6a37b0ed&t=//chrome/cloudcast/client/gamerx/audio/test:active_controller_audio_service_test_ddc_headless-chrome-linux *** Original change description *** Import #376 *** PiperOrigin-RevId: 367295097
srawlins
added a commit
that referenced
this pull request
Apr 12, 2021
*** Reason for rollback *** Roll forward after fixes *** Original change description *** Automated g4 rollback of changelist 367238585. *** Reason for rollback *** Broke https://test.corp.google.com/ui#cl=365134781&flags=CAMQBQ==&id=OCL:365134781:BASE:367271161:1617822936639:6a37b0ed&t=//chrome/cloudcast/client/gamerx/audio/test:active_controller_audio_service_test_ddc_headless-chrome-linux *** Original change description *** Import #376 *** *** PiperOrigin-RevId: 367657308
srawlins
added a commit
that referenced
this pull request
Apr 12, 2021
srawlins
added a commit
that referenced
this pull request
Apr 12, 2021
*** Reason for rollback *** Broke https://test.corp.google.com/ui#cl=365134781&flags=CAMQBQ==&id=OCL:365134781:BASE:367271161:1617822936639:6a37b0ed&t=//chrome/cloudcast/client/gamerx/audio/test:active_controller_audio_service_test_ddc_headless-chrome-linux *** Original change description *** Import #376 *** PiperOrigin-RevId: 367295097
srawlins
added a commit
that referenced
this pull request
Apr 12, 2021
*** Reason for rollback *** Roll forward after fixes *** Original change description *** Automated g4 rollback of changelist 367238585. *** Reason for rollback *** Broke https://test.corp.google.com/ui#cl=365134781&flags=CAMQBQ==&id=OCL:365134781:BASE:367271161:1617822936639:6a37b0ed&t=//chrome/cloudcast/client/gamerx/audio/test:active_controller_audio_service_test_ddc_headless-chrome-linux *** Original change description *** Import #376 *** *** PiperOrigin-RevId: 367657308
srawlins
added a commit
that referenced
this pull request
Apr 12, 2021
srawlins
added a commit
that referenced
this pull request
Apr 12, 2021
*** Reason for rollback *** Broke https://test.corp.google.com/ui#cl=365134781&flags=CAMQBQ==&id=OCL:365134781:BASE:367271161:1617822936639:6a37b0ed&t=//chrome/cloudcast/client/gamerx/audio/test:active_controller_audio_service_test_ddc_headless-chrome-linux *** Original change description *** Import #376 *** PiperOrigin-RevId: 367295097
srawlins
added a commit
that referenced
this pull request
Apr 12, 2021
*** Reason for rollback *** Roll forward after fixes *** Original change description *** Automated g4 rollback of changelist 367238585. *** Reason for rollback *** Broke https://test.corp.google.com/ui#cl=365134781&flags=CAMQBQ==&id=OCL:365134781:BASE:367271161:1617822936639:6a37b0ed&t=//chrome/cloudcast/client/gamerx/audio/test:active_controller_audio_service_test_ddc_headless-chrome-linux *** Original change description *** Import #376 *** *** PiperOrigin-RevId: 367657308
srawlins
added a commit
that referenced
this pull request
Sep 13, 2022
The big change affecting all of the goldens is that we now add trailing commas. The motivation is that code with trailing commas can avoid pathological corners of the formatter, which can save entire seconds in generating some Dart source code. See details at: dart-lang/code_builder#376 - f635ab6e2776955d057cf75757905f73f76adbd9 Add support for trailing commas in Emitter (#376) by Sam Rawlins <srawlins@google.com> - e082adb3e01d619370e7ec14b5f8ae6ac8ecf903 Fix spelling in README.md (#360) by Saint Gabriel <53136855+chineduG@users.noreply.github.com> - bed3ca90fb5a42b2b4c7fc93a8d73652a06d4314 Fix spelling in CHANGELOG.md (#361) by Saint Gabriel <53136855+chineduG@users.noreply.github.com> PiperOrigin-RevId: 469597645
srawlins
added a commit
that referenced
this pull request
Sep 13, 2022
The big change affecting all of the goldens is that we now add trailing commas. The motivation is that code with trailing commas can avoid pathological corners of the formatter, which can save entire seconds in generating some Dart source code. See details at: dart-lang/code_builder#376 - f635ab6e2776955d057cf75757905f73f76adbd9 Add support for trailing commas in Emitter (#376) by Sam Rawlins <srawlins@google.com> - e082adb3e01d619370e7ec14b5f8ae6ac8ecf903 Fix spelling in README.md (#360) by Saint Gabriel <53136855+chineduG@users.noreply.github.com> - bed3ca90fb5a42b2b4c7fc93a8d73652a06d4314 Fix spelling in CHANGELOG.md (#361) by Saint Gabriel <53136855+chineduG@users.noreply.github.com> PiperOrigin-RevId: 469597645
srawlins
added a commit
that referenced
this pull request
Sep 13, 2022
The big change affecting all of the goldens is that we now add trailing commas. The motivation is that code with trailing commas can avoid pathological corners of the formatter, which can save entire seconds in generating some Dart source code. See details at: dart-lang/code_builder#376 - f635ab6e2776955d057cf75757905f73f76adbd9 Add support for trailing commas in Emitter (#376) by Sam Rawlins <srawlins@google.com> - e082adb3e01d619370e7ec14b5f8ae6ac8ecf903 Fix spelling in README.md (#360) by Saint Gabriel <53136855+chineduG@users.noreply.github.com> - bed3ca90fb5a42b2b4c7fc93a8d73652a06d4314 Fix spelling in CHANGELOG.md (#361) by Saint Gabriel <53136855+chineduG@users.noreply.github.com> PiperOrigin-RevId: 469597645
srawlins
added a commit
that referenced
this pull request
Sep 14, 2022
The big change affecting all of the goldens is that we now add trailing commas. The motivation is that code with trailing commas can avoid pathological corners of the formatter, which can save entire seconds in generating some Dart source code. See details at: dart-lang/code_builder#376 - f635ab6e2776955d057cf75757905f73f76adbd9 Add support for trailing commas in Emitter (#376) by Sam Rawlins <srawlins@google.com> - e082adb3e01d619370e7ec14b5f8ae6ac8ecf903 Fix spelling in README.md (#360) by Saint Gabriel <53136855+chineduG@users.noreply.github.com> - bed3ca90fb5a42b2b4c7fc93a8d73652a06d4314 Fix spelling in CHANGELOG.md (#361) by Saint Gabriel <53136855+chineduG@users.noreply.github.com> PiperOrigin-RevId: 469597645
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds a test for verify failing when given a non-mock call, which is currently untested.
Without this change, this mistake is possible and horrific:
Which just always passes (assuming those calls don't throw), as does e.g.
verifyInOrder(['banana']);