Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make verifyInOrder fail given non-mock-calls. #376

Merged
merged 1 commit into from
Mar 24, 2021
Merged

Make verifyInOrder fail given non-mock-calls. #376

merged 1 commit into from
Mar 24, 2021

Conversation

ravenblackx
Copy link
Contributor

Also adds a test for verify failing when given a non-mock call, which is currently untested.

Without this change, this mistake is possible and horrific:

verifyInOrder([
  fakeService.someCall(),
  fakeService.someOtherCall(),
]);

Which just always passes (assuming those calls don't throw), as does e.g. verifyInOrder(['banana']);

@ravenblackx
Make verifyInOrder fail given non-mock-calls.
729364c 
Also adds a test for verify failing when given a non-mock call.
@google-cla google-cla bot added the cla: yes label Mar 24, 2021
srawlins
srawlins approved these changes Mar 24, 2021
View reviewed changes
Copy link
Member

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@srawlins srawlins merged commit 88e434a into dart-lang:master Mar 24, 2021
srawlins added a commit that referenced this pull request Apr 7, 2021
@srawlins
Import #376
bc127ca 
PiperOrigin-RevId: 367238585
srawlins added a commit that referenced this pull request Apr 12, 2021
@srawlins
Import #376
fba4d43 
PiperOrigin-RevId: 367238585
srawlins added a commit that referenced this pull request Apr 12, 2021
@srawlins
Automated g4 rollback of changelist 367238585.
687941f 
*** Reason for rollback ***

Broke https://test.corp.google.com/ui#cl=365134781&flags=CAMQBQ==&id=OCL:365134781:BASE:367271161:1617822936639:6a37b0ed&t=//chrome/cloudcast/client/gamerx/audio/test:active_controller_audio_service_test_ddc_headless-chrome-linux

*** Original change description ***

Import #376

***

PiperOrigin-RevId: 367295097
srawlins added a commit that referenced this pull request Apr 12, 2021
@srawlins
Automated g4 rollback of changelist 367295097.
f35ae8c 
*** Reason for rollback ***

Roll forward after fixes

*** Original change description ***

Automated g4 rollback of changelist 367238585.

*** Reason for rollback ***

Broke https://test.corp.google.com/ui#cl=365134781&flags=CAMQBQ==&id=OCL:365134781:BASE:367271161:1617822936639:6a37b0ed&t=//chrome/cloudcast/client/gamerx/audio/test:active_controller_audio_service_test_ddc_headless-chrome-linux

*** Original change description ***

Import #376

***

***

PiperOrigin-RevId: 367657308
srawlins added a commit that referenced this pull request Apr 12, 2021
@srawlins
Import #376
5d1c3e8 
PiperOrigin-RevId: 367238585
srawlins added a commit that referenced this pull request Apr 12, 2021
@srawlins
Automated g4 rollback of changelist 367238585.
bd5b883 
*** Reason for rollback ***

Broke https://test.corp.google.com/ui#cl=365134781&flags=CAMQBQ==&id=OCL:365134781:BASE:367271161:1617822936639:6a37b0ed&t=//chrome/cloudcast/client/gamerx/audio/test:active_controller_audio_service_test_ddc_headless-chrome-linux

*** Original change description ***

Import #376

***

PiperOrigin-RevId: 367295097
srawlins added a commit that referenced this pull request Apr 12, 2021
@srawlins
Automated g4 rollback of changelist 367295097.
0722fb3 
*** Reason for rollback ***

Roll forward after fixes

*** Original change description ***

Automated g4 rollback of changelist 367238585.

*** Reason for rollback ***

Broke https://test.corp.google.com/ui#cl=365134781&flags=CAMQBQ==&id=OCL:365134781:BASE:367271161:1617822936639:6a37b0ed&t=//chrome/cloudcast/client/gamerx/audio/test:active_controller_audio_service_test_ddc_headless-chrome-linux

*** Original change description ***

Import #376

***

***

PiperOrigin-RevId: 367657308
srawlins added a commit that referenced this pull request Apr 12, 2021
@srawlins
Import #376
10cd1fc 
PiperOrigin-RevId: 367238585
srawlins added a commit that referenced this pull request Apr 12, 2021
@srawlins
Automated g4 rollback of changelist 367238585.
e9b5aaa 
*** Reason for rollback ***

Broke https://test.corp.google.com/ui#cl=365134781&flags=CAMQBQ==&id=OCL:365134781:BASE:367271161:1617822936639:6a37b0ed&t=//chrome/cloudcast/client/gamerx/audio/test:active_controller_audio_service_test_ddc_headless-chrome-linux

*** Original change description ***

Import #376

***

PiperOrigin-RevId: 367295097
srawlins added a commit that referenced this pull request Apr 12, 2021
@srawlins
Automated g4 rollback of changelist 367295097.
7de061c 
*** Reason for rollback ***

Roll forward after fixes

*** Original change description ***

Automated g4 rollback of changelist 367238585.

*** Reason for rollback ***

Broke https://test.corp.google.com/ui#cl=365134781&flags=CAMQBQ==&id=OCL:365134781:BASE:367271161:1617822936639:6a37b0ed&t=//chrome/cloudcast/client/gamerx/audio/test:active_controller_audio_service_test_ddc_headless-chrome-linux

*** Original change description ***

Import #376

***

***

PiperOrigin-RevId: 367657308
srawlins added a commit that referenced this pull request Sep 13, 2022
@srawlins
code_builder import from GitHub.
201a1ff 
The big change affecting all of the goldens is that we now add trailing commas.
The motivation is that code with trailing commas can avoid pathological corners
of the formatter, which can save entire seconds in generating some Dart source
code.

See details at: dart-lang/code_builder#376

  - f635ab6e2776955d057cf75757905f73f76adbd9 Add support for trailing commas in Emitter (#376) by Sam Rawlins <srawlins@google.com>
  - e082adb3e01d619370e7ec14b5f8ae6ac8ecf903 Fix spelling in README.md (#360) by Saint Gabriel <53136855+chineduG@users.noreply.github.com>
  - bed3ca90fb5a42b2b4c7fc93a8d73652a06d4314 Fix spelling in CHANGELOG.md (#361) by Saint Gabriel <53136855+chineduG@users.noreply.github.com>

PiperOrigin-RevId: 469597645
srawlins added a commit that referenced this pull request Sep 13, 2022
@srawlins
code_builder import from GitHub.
d3658b7 
The big change affecting all of the goldens is that we now add trailing commas.
The motivation is that code with trailing commas can avoid pathological corners
of the formatter, which can save entire seconds in generating some Dart source
code.

See details at: dart-lang/code_builder#376

  - f635ab6e2776955d057cf75757905f73f76adbd9 Add support for trailing commas in Emitter (#376) by Sam Rawlins <srawlins@google.com>
  - e082adb3e01d619370e7ec14b5f8ae6ac8ecf903 Fix spelling in README.md (#360) by Saint Gabriel <53136855+chineduG@users.noreply.github.com>
  - bed3ca90fb5a42b2b4c7fc93a8d73652a06d4314 Fix spelling in CHANGELOG.md (#361) by Saint Gabriel <53136855+chineduG@users.noreply.github.com>

PiperOrigin-RevId: 469597645
srawlins added a commit that referenced this pull request Sep 13, 2022
@srawlins
code_builder import from GitHub.
0922af2 
The big change affecting all of the goldens is that we now add trailing commas.
The motivation is that code with trailing commas can avoid pathological corners
of the formatter, which can save entire seconds in generating some Dart source
code.

See details at: dart-lang/code_builder#376

  - f635ab6e2776955d057cf75757905f73f76adbd9 Add support for trailing commas in Emitter (#376) by Sam Rawlins <srawlins@google.com>
  - e082adb3e01d619370e7ec14b5f8ae6ac8ecf903 Fix spelling in README.md (#360) by Saint Gabriel <53136855+chineduG@users.noreply.github.com>
  - bed3ca90fb5a42b2b4c7fc93a8d73652a06d4314 Fix spelling in CHANGELOG.md (#361) by Saint Gabriel <53136855+chineduG@users.noreply.github.com>

PiperOrigin-RevId: 469597645
srawlins added a commit that referenced this pull request Sep 14, 2022
@srawlins
code_builder import from GitHub.
d168308 
The big change affecting all of the goldens is that we now add trailing commas.
The motivation is that code with trailing commas can avoid pathological corners
of the formatter, which can save entire seconds in generating some Dart source
code.

See details at: dart-lang/code_builder#376

  - f635ab6e2776955d057cf75757905f73f76adbd9 Add support for trailing commas in Emitter (#376) by Sam Rawlins <srawlins@google.com>
  - e082adb3e01d619370e7ec14b5f8ae6ac8ecf903 Fix spelling in README.md (#360) by Saint Gabriel <53136855+chineduG@users.noreply.github.com>
  - bed3ca90fb5a42b2b4c7fc93a8d73652a06d4314 Fix spelling in CHANGELOG.md (#361) by Saint Gabriel <53136855+chineduG@users.noreply.github.com>

PiperOrigin-RevId: 469597645
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srawlins srawlins srawlins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ravenblackx @srawlins