Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest build_web_compilers, move to pkg:lints, fix breaks #605

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Conversation

kevmoo
Copy link
Member

@kevmoo kevmoo commented Jan 30, 2023

No description provided.

@kevmoo
Copy link
Member Author

kevmoo commented Jan 30, 2023

Feel free to squash/merge and delete the branch if you're happy

@kevmoo kevmoo merged commit d2a8df1 into master Jan 30, 2023
@kevmoo kevmoo deleted the cleanup branch January 30, 2023 18:17
natebosch pushed a commit that referenced this pull request Mar 23, 2023
Latest build_web_compilers, move to pkg:lints, fix breaks

PiperOrigin-RevId: 511423456
natebosch added a commit that referenced this pull request Mar 24, 2023
* Import #605

Latest build_web_compilers, move to pkg:lints, fix breaks

PiperOrigin-RevId: 511423456

* Import ed5bd84

Relax mixin criteria

Remove the restriction that mixins must implement the mocked type so that [MockPlatformInterfaceMixin](https://pub.dev/documentation/plugin_platform_interface/latest/plugin_platform_interface/MockPlatformInterfaceMixin-class.html) can be used.

Fixes #603

PiperOrigin-RevId: 511486389

* Tidy up some fixes which were automatically applied and made lines longer than 80 chars.

These are easier to read when wrapped consistently like all other strings in the code.

PiperOrigin-RevId: 511490379

* Add a default generate_for

Closes #502

Most users only need mocks for test files. The mockito generator performs
resolution, so running the generator across all files in `lib/` that are
unlikley to use mocks is not worthwhile.

Users who do want mocks generated for files in `lib/` will need to manually add
a `generate_for` configuration.

PiperOrigin-RevId: 512017662

* Prevent '?' on 'Null' type.
Generated code:
- before: "void trigger(Null? event)"
- after:  "void trigger(Null event)"

PiperOrigin-RevId: 512927949

---------

Co-authored-by: srawlins <srawlins@google.com>
Co-authored-by: Googler <noreply@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants