Throw an ArgumentError if thenReturn is called with futures or streams.
#88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, documented this behavior in the README. This fixes dart-lang#79.
|
I updated the change log to document this since it's a breaking change. I just put down version number 2.3.0. Let me know if I should change it. |
|
Looks like this is failing on Dart 1.21.1, because assert message support wasn't added until Dart 1.22. I think providing a message is valuable, so I'll change this to return an ArgumentError. |
This will allow us to support Dart versions that don't support assert messages.
alanrussian
changed the title
thenReturn isn't called with futures nor streams.thenReturn is called with futures or streams.
TedSander
approved these changes
Dec 12, 2017
matanlurey
reviewed
Dec 12, 2017
| @@ -1,3 +1,9 @@ | |||
| ## 2.3.0 | |||
There was a problem hiding this comment.
Sort of late, but this should be 3.0.0.
There was a problem hiding this comment.
Fix here... the pubspec wasn't updated either: #89
srawlins
added a commit
that referenced
this pull request
Feb 8, 2018
* master: Capture T in `verify`+ so T may be `void` in dart 2: `verify(m.void())` (#90) Tag the version as 3.0.0-alpha Bump version to 3.0.0 (#89) Throw an ArgumentError if `thenReturn` is called with futures or streams. (#88) Fix uses_dynamic_as_bottom error (#86) Remove Dev from the pubspec version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, documented this behavior in the README.
This fixes #79.