Updated tag detection for packages without a primary library.

[isoos]

• Fixes linter: missing sdk.version... a little help? #591.
• Top-level libraries are the files in lib/*.dart. However, if there is a primary library in the package (/lib/[package_name].dart), it will be used as a single value in top-level libraries.
• Tags are added when all of the top-level libraries agree on supporting the given SDK or platform.
• Binary-only packages are handled via a temporary heuristic.

[pq]

Thank you @isoos!

[sigurdm]

Thanks for looking into this!

LGTM for the short-term, but ideally we should recognise packages that are mainly executable and have another tagging scheme for them, or at least use their declared executables from the pubspec as root libraries.

[isoos]

ideally we should recognise packages that are mainly executable and have another tagging scheme for them, or at least use their declared executables from the pubspec as root libraries.

I'm not entirely sure that we should treat them that much different on this stage of the analysis. E.g. in case of package:linter, while it may be a "binary-only" package, I can still import its internals (lib/src/.../whatever.dart), use them, and they may just work fine.

Of course we should also tag "binary-only" status, which would change the instructions on the "Install tab"...

[sigurdm]

I can still import its internals (lib/src/.../whatever.dart), use them, and they may just work fine.

You can, but the convention is to not import internals, and I don't think we should provide an analysis that suggests what works in case you break the convention.

[isoos]

That's a good point. Should I remove the lib/src part from this one, or are we doing that later?

[sigurdm]

Could you look up the executables, and use those in case there are nothing in lib/ ?

[isoos]

I've updated the PR, checking the bin/ directory for files, but only with a (probably temporary) heuristic:

• not checking the pubspec.executables, because it is optionals, and many binary packages, including package:linter and my own codegen library ignored it (it is useful for having an alias, but not a requirement for pub run ...)
• it returns sdk:dart and runtime:native-* as tags, without really checking the referenced libraries

[pq]

Fantastic! Any chance you could push out a release with this fix?

Much appreciated!

[isoos]

@pq: Unfortunately there are no production deployments around the holidays, I'd expect this to get into prod in early January.

[pq]

No worries. That makes perfect sense.

Hope you enjoy some time off! ❄️