-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring over latest files from flutter/packages #46
Conversation
|
After the diff above, replaced the Flutter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
example/analysis_options.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with dart-lang
-owned package conventions; is it normal to have a custom analysis options for the example directory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know, but I'd expect examples to use lints/recommended
, to be written for users using those lints, and the package itself to use dart_flutter_team_lints
(or whatever it's called, I can never remember, or seem to find it when I need it).
Could probably use the same lints everywhere, since the dart/flutter team lints includes everything in recommended, and probably won't add many extra restrictions for traditional example code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wasn't strictly needed before, but now example and package use different lints, so now it's needed
example/pubspec.yaml
Outdated
publish_to: none | ||
|
||
environment: | ||
sdk: ^3.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably use 3.2 like the package itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
pubspec.yaml
Outdated
|
||
dev_dependencies: | ||
lints: ^1.0.1 | ||
lints: ^4.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use dart_flutter_team_lints
?
(Not that I prefer them, but they exist now.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
The source code for `package:platform` has been moved to https://github.com/dart-lang/platform/, see dart-lang/platform#46 This PR removes the source from this repo, and leave a small cookie trail README in place.
The source code for `package:platform` has been moved to https://github.com/dart-lang/platform/, see dart-lang/platform#46 This PR removes the source from this repo, and leave a small cookie trail README in place.
As a first step in moving the source location , this PR moves over the latest files from
I’ve reviewed the contributor guide and applied the relevant portions to this PR.
See our contributor guide for general expectations for PRs.
Larger or significant changes should be discussed in an issue before creating a PR.
Contributions to our repos should follow the Dart style guide and use
dart format
.Most changes should add an entry to the changelog and may need to rev the pubspec package version.
Changes to packages require corresponding tests.
Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.