Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring over latest files from flutter/packages #46

Merged
merged 4 commits into from
Jun 10, 2024
Merged

Bring over latest files from flutter/packages #46

merged 4 commits into from
Jun 10, 2024

Conversation

mit-mit
Copy link
Member

@mit-mit mit-mit commented Jun 10, 2024

As a first step in moving the source location , this PR moves over the latest files from


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.

  • See our contributor guide for general expectations for PRs.

  • Larger or significant changes should be discussed in an issue before creating a PR.

  • Contributions to our repos should follow the Dart style guide and use dart format.

  • Most changes should add an entry to the changelog and may need to rev the pubspec package version.

  • Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@mit-mit
Copy link
Member Author

mit-mit commented Jun 10, 2024

$ diff -qr ~/dev/flutter_packages/packages/platform/ .
Only in .: .git
Only in .: .github
Files /Users/mit/dev/flutter_packages/packages/platform/CHANGELOG.md and ./CHANGELOG.md differ
Only in .: CONTRIBUTING.md
Files /Users/mit/dev/flutter_packages/packages/platform/LICENSE and ./LICENSE differ
Only in .: analysis_options.yaml
Only in /Users/mit/dev/flutter_packages/packages/platform: dart_test.yaml
Files /Users/mit/dev/flutter_packages/packages/platform/pubspec.yaml and ./pubspec.yaml differ
$ diff ~/dev/flutter_packages/packages/platform/CHANGELOG.md CHANGELOG.md
3a4,5
> * Transfers the package source from https://github.com/flutter/packages
>   to https://github.com/dart-lang/platform.
$ diff ~/dev/flutter_packages/packages/platform/pubspec.yaml pubspec.yaml
3,4c3,4
< repository: https://github.com/flutter/packages/tree/main/packages/platform
< issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+platform%22
---
> repository: https://github.com/dart-lang/platform
> issue_tracker: https://github.com/dart-lang/platform/issues
10a11
>   lints: ^4.0.0

@mit-mit
Copy link
Member Author

mit-mit commented Jun 10, 2024

After the diff above, replaced the Flutter example/ with a plain Dart console one.

Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with dart-lang-owned package conventions; is it normal to have a custom analysis options for the example directory?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, but I'd expect examples to use lints/recommended, to be written for users using those lints, and the package itself to use dart_flutter_team_lints (or whatever it's called, I can never remember, or seem to find it when I need it).

Could probably use the same lints everywhere, since the dart/flutter team lints includes everything in recommended, and probably won't add many extra restrictions for traditional example code.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't strictly needed before, but now example and package use different lints, so now it's needed

publish_to: none

environment:
sdk: ^3.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably use 3.2 like the package itself.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

pubspec.yaml Outdated

dev_dependencies:
lints: ^1.0.1
lints: ^4.0.0
Copy link
Member

@lrhn lrhn Jun 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use dart_flutter_team_lints?
(Not that I prefer them, but they exist now.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@mit-mit mit-mit merged commit 0a7f0ce into master Jun 10, 2024
11 checks passed
@mit-mit mit-mit deleted the mirror branch June 10, 2024 13:39
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jun 10, 2024
The source code for `package:platform` has been moved to https://github.com/dart-lang/platform/, see dart-lang/platform#46

This PR removes the source from this repo, and leave a small cookie trail README in place.
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
The source code for `package:platform` has been moved to https://github.com/dart-lang/platform/, see dart-lang/platform#46

This PR removes the source from this repo, and leave a small cookie trail README in place.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants