-
Notifications
You must be signed in to change notification settings - Fork 17
Port the gold-elements tests! #3
Comments
Hi Jacob, |
I also added In terms of tests that require you to create an example element, those are usually tests for behaviors, which are blocked on dart-archive/polymer-dart#551. These can all be skipped for now. Other tests which create custom elements you can just keep the js custom element from the original test in most cases. |
Ok merged the iron-element tests that I have done into master so you can see a lot more examples there. The main piece missing right now is nice server mocking, so you may need to skip some tests until we have that, you can link #16 as the skip message for any of those. |
Working on this one. It'll be ready soon. |
great! |
Is there a server where tests for PolymerJS elements are running? Some of my tests are failing and I want to check results for original tests. |
Actually, do you have any advice how should I run tests before creating pull request? |
I had the same question regarding the polymerjs tests. @vsheyanov Some of the polymerjs tests are out of date. For example, it looks like the tests in polymerjs for gold-email-input don't match the current implementation of the element. The js tests check for display: none for the error, but the implementation is using visibility:hidden. You can toss elements into a demo app to help figure out if it's the test or the element that's the problem. You can also look at the issues in the element's repo to see known problems and sometimes if tests are failing. |
They do have a CI server, but I have noticed its not integrated into all of the repos. If any tests are failing please mark them as You can also check the original github repos and see if there is a more updated test. |
@vsheyanov running the js tests standalone is a bit of a pain, you will need to install node/npm and bower. Essentially the process is this:
Doing this should give you a renewed appreciation for dart :) |
@vsheyanov To run all the tests on the dart side of things, just do |
@ErikGrimes thanks, issue with display:none is one of that I've found out. And wanted to ask if it should be changed to visibility :) @jakemac53 I took all tests from original repo, so that should be fine. |
Hi guys, I'm trying to run all tests using When I run tests in chrome - they are executed sequentially as expected... and yes, it on Windows... |
I recently submitted some fixes for flaky timeouts relating to the iron-* and google-* tests, so if that's what you were seeing then you can try just rebasing on master and it will probably fix your issues. |
closed by #23 |
Part of #1.
The text was updated successfully, but these errors were encountered: