Skip to content
This repository has been archived by the owner on Dec 19, 2017. It is now read-only.

Port all the tests! #1

Closed
7 tasks done
jakemac53 opened this issue Aug 5, 2015 · 6 comments
Closed
7 tasks done

Port all the tests! #1

jakemac53 opened this issue Aug 5, 2015 · 6 comments

Comments

@jakemac53
Copy link
Contributor

Community involvement on this one would be great, as there are north of 170 elements/behaviors total. To that end, and also for my own sanity, I am separating this out into a bunch of sub-tasks.

The goal is to just port all existing js tests, not to write tests of our own.

@jakemac53 jakemac53 added this to the 1.0 milestone Aug 5, 2015
@jakemac53
Copy link
Contributor Author

There are a number of iron-* tests in the repo which can be used as examples, and the common.dart file contains various helpers.

@jakemac53
Copy link
Contributor Author

Also, fwiw any tests for behaviors should be skipped for now, as they are blocked on dart-archive/polymer-dart#551

@jakemac53
Copy link
Contributor Author

If any type signatures are wrong (discovering these is actually one of the main purposes of these tests), then proper annotations need to be added to the original js files under lib/src, and a pull request should be sent to the original repo as well.

The wrappers need to be regenerated once that is done, this can be accomplished by globally installing the hydrolysis package with npm (must install node/npm first), and then running pub run custom_element_apigen:update polymer_elements_config.yaml. Make sure you have version 1.15.3 or greater of the hydrolysis package, as the previous version doesn't pick up certain types of behaviors, which results in an error in the update script.

@jakemac53
Copy link
Contributor Author

Ok I think we are done! Thanks a bunch @ErikGrimes and @vsheyanov for the help, that was a doozy :)

@vsheyanov
Copy link
Contributor

Great news! Glad to help :)

@ErikGrimes
Copy link
Contributor

Awesome!

jakemac53 pushed a commit to jakemac53/polymer_elements that referenced this issue Jul 1, 2016
…60616

update pubspec, firebase_query_behavior
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

3 participants