Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/api/packages/versions/newUploadFinish logs warning if package is already uploaded #1456

Closed
sortie opened this issue Jul 13, 2018 · 1 comment
Milestone

Comments

@sortie
Copy link

sortie commented Jul 13, 2018

The /api/packages/versions/newUploadFinish API logs a warning if a package is already uploaded:

pubserver.shelf_pubserver: An error occured while finishing upload

Error:
    Exception: Version 0.6.0 of package exifdart already exists.

I don't believe this matters enough to us that we log a warning, the uploader gets the warning and can figure out the problem. Can we demote this case to an info? Of course, if any other unexpected upload error happens, we should log a error/warning.

@sortie sortie added this to the M8 milestone Jul 13, 2018
@isoos
Copy link
Collaborator

isoos commented Jul 23, 2018

I think the log event comes from package:pub_server, from this line. There seem to be legitimate cases where this event warrants a logger.warning.

However, if there were special exception types for errors that are supposed to be corrected by the user, the same code block could differentiate between the log levels.

Filed dart-archive/pub_server#17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants