Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable searching for Flutter plugins specifying supported native platforms (e.g. Android, iOS) #187

Closed
mit-mit opened this issue Jun 22, 2017 · 19 comments

Comments

@mit-mit
Copy link
Member

mit-mit commented Jun 22, 2017

When searching among Flutter packages, support narrowing the search to only packages that work on a particular platform (android, ios, web, desktop)

@mit-mit mit-mit added this to the M3 milestone Jun 22, 2017
@mit-mit
Copy link
Member Author

mit-mit commented Jun 22, 2017

Related bug for package detail page: #144

@mit-mit
Copy link
Member Author

mit-mit commented Jun 22, 2017

Blocked on flutter/flutter#10288

@kevmoo kevmoo added the P1 high label Jun 23, 2017
@kevmoo
Copy link
Member

kevmoo commented Oct 24, 2017

@mit-mit Moving this to M4. We can re-triage once there is a plan on the flutter side to provide the needed info

@kevmoo kevmoo modified the milestones: M3, M4 Oct 24, 2017
@isoos
Copy link
Collaborator

isoos commented Nov 21, 2017

@mit-mit: what is the latest on detecting whether a package works on ios, android or both?

@kevmoo
Copy link
Member

kevmoo commented Nov 21, 2017

I marked this as M4 – since we have no plan in the short term to address this

@mit-mit
Copy link
Member Author

mit-mit commented Nov 21, 2017

Correct, we don't have platform support for this yet.

@MarkOSullivan94
Copy link

Any estimation on when this will arrive? Could imagine there'll be an increase in packages published the more popular Flutter becomes

@jaumard
Copy link

jaumard commented Mar 27, 2019

Also would be nice to be able to filter if it's Java/objC vs kotlin/swift as kotlin/swift is more painful to maintain and personally I try to avoid them

@jonasfj
Copy link
Member

jonasfj commented Mar 27, 2019

@jaumard, analyzing language usages would be interesting I filed #2154 for this. But it's definitely a separate issue, though it might mitigate this issue.

@MarkOSullivan94
Copy link

Would be perfect if there was a way to request help from people with iOS side for packages which only have Android side implemented and vice versa

@fmatosqg
Copy link

@jaumard what are the issues with kotlin?

@jaumard
Copy link

jaumard commented Mar 28, 2019

@fmatosqg when you have multiple flutter plugin using kotlin, if one have an old version of kotlin your all project doesn't compile anymore... Or the opposite one plugin is really up to date but not you, still you can't compile unless you migrate all your plugin to the same kotlin version (or acceptable range of versions) but maybe one plugin is not yours and you're blocked...

It's exactly same story as swift. That's why I ban those languages for flutter plugins. And I've seen many plugins migrate to Java/objC from swift/kotlin because of that, because maintaining an open source plugin using those languages force you to update then just to have languages version up to date, even if there no new feature or bug fixing.

@fmatosqg
Copy link

fmatosqg commented Mar 28, 2019

@jaumard having worked with kotlin for a while in native android this is an interesting surprise, specially considering how strong backwards compatibility is. I'd be very interesting in seeing that failing for myself, can you post a link to such a project?

Now on the swift side I know how painful it can be, but that's the first time I hear similar issues on kotlin for any platform or framework. My obvious suggestion is upgrading your project to the latest version. Maybe we need to add that to documentation, maybe we need a tool to do it for people.

@jaumard
Copy link

jaumard commented Mar 29, 2019

@fmatosqg I've worked a lot with kotlin myself and had no issues for android projects, but with flutter it's not the same story because plugins are loaded as "module" on our project, meaning they have they're own gradle/kotlin supported version and that's the problem as they can use a very old version and you'll not be able to compile anymore.

So even if you are upgrading your project to the latest version, it doesn't mean that all the plugin you use will do too. I don't have a link to provide as it's my company project and it doesn't fail anymore as we migrate to only java/objC plugins to avoid those problems. but you can check geolocator or flutter_crashlytics who are plugin that has made the migration back to those languages

@MarkOSullivan94
Copy link

I feel like there should be some warning making everyone aware of what you're talking about @jaumard. Would be very useful whenever creating new projects and just informative on the Flutter docs.

You should open a PR on the Flutter website and add that key piece of information.

@jaumard
Copy link

jaumard commented Apr 2, 2019

I'm agree with, but I'm not sure it will be accepted @MarkOSullivan94 as saying "Swift/Kotlin is considered bad practice for Flutter plugin and should be avoided" might not be a good selling point ^^
I don't want to waste time making a PR for nothing :) but making a medium for good practice for Flutter plugins might be good yes (but maybe there already some ^^)

@jonasfj
Copy link
Member

jonasfj commented Apr 3, 2019

@jaumard, @MarkOSullivan94, whether to discourage swift/kotlin is a flutter concern, maybe @amirh have more insights on this. In any event it seems like something worth debating in a Flutter issue :)

@yjbanov
Copy link

yjbanov commented Sep 13, 2019

Please also add the Web to the list of platforms to search by.

@yjbanov
Copy link

yjbanov commented Sep 13, 2019

See, e.g. flutter/flutter#40360

@mit-mit mit-mit changed the title Enable searching for Flutter plugins specifying supported native platforms (Android, or iOS, or both) Enable searching for Flutter plugins specifying supported native platforms (e.g. Android, iOS) Oct 8, 2019
@isoos isoos closed this as completed Dec 11, 2019
@isoos isoos removed this from the Backlog milestone Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants