non-nullable isModerated flags

app/lib/account/models.dart

@@ -56,7 +56,7 @@ class User extends db.ExpandoModel<String> {
 
   /// `true` if user was moderated (pending moderation or deletion).
   @db.BoolProperty(required: true)
-  bool? isModerated;
+  bool isModerated = false;
 
   /// The timestamp when the user was moderated.
   @db.DateTimeProperty()
@@ -69,7 +69,7 @@ class User extends db.ExpandoModel<String> {
     isModerated = false;
   }
 
-  late final isVisible = !isBlocked && !(isModerated ?? false);
+  late final isVisible = !isBlocked && !isModerated;
   late final isNotVisible = !isVisible;
 }
 

app/lib/package/models.dart

@@ -139,7 +139,7 @@ class Package extends db.ExpandoModel<String> {
 
   /// `true` if package was moderated (pending moderation or deletion).
   @db.BoolProperty(required: true)
-  bool? isModerated;
+  bool isModerated = false;
 
   /// The timestamp when the package was moderated.
   @db.DateTimeProperty()
@@ -202,13 +202,13 @@ class Package extends db.ExpandoModel<String> {
 
   // Convenience Fields:
 
-  bool get isVisible => !isBlocked && !(isModerated ?? false);
+  bool get isVisible => !isBlocked && !isModerated;
   bool get isNotVisible => !isVisible;
 
   bool get isIncludedInRobots {
     final now = clock.now();
     return isVisible &&
-        !(isModerated ?? false) &&
+        !isModerated &&
         !isDiscontinued &&
         !isUnlisted &&
         now.difference(created!) > robotsVisibilityMinAge &&
@@ -599,7 +599,7 @@ class PackageVersion extends db.ExpandoModel<String> {
 
   /// `true` if package version was moderated (pending moderation or deletion).
   @db.BoolProperty(required: true)
-  bool? isModerated;
+  bool isModerated = false;
 
   /// The timestamp when the package version was moderated.
   @db.DateTimeProperty()

app/lib/publisher/models.dart

@@ -66,7 +66,7 @@ class Publisher extends db.ExpandoModel<String> {
 
   /// `true` if publisher was moderated (pending moderation or deletion).
   @db.BoolProperty(required: true)
-  bool? isModerated;
+  bool isModerated = false;
 
   /// The timestamp when the publisher was moderated.
   @db.DateTimeProperty()

app/lib/shared/integrity.dart

@@ -911,16 +911,13 @@ class _PublisherAttributes {
 Stream<String> _checkModeratedFlags({
   required String kind,
   required String id,
-  required bool? isModerated,
+  required bool isModerated,
   required DateTime? moderatedAt,
 }) async* {
-  if (isModerated == null) {
-    yield '$kind "$id" has an `isModerated` property which is null.';
-  }
-  if ((isModerated ?? false) && moderatedAt == null) {
+  if (isModerated && moderatedAt == null) {
     yield '$kind "$id" has `isModerated = true` but `moderatedAt` is null.';
   }
-  if (!(isModerated ?? false) && moderatedAt != null) {
+  if (!isModerated && moderatedAt != null) {
     yield '$kind "$id" has `isModerated = false` but `moderatedAt` is not null.';
   }
 }

app/lib/tool/maintenance/update_public_bucket.dart

@@ -57,8 +57,7 @@ Future<PublicBucketUpdateStat> updatePublicArchiveBucket({
     if (lastPackage?.name != pv.package) {
       lastPackage = await packageBackend.lookupPackage(pv.package);
     }
-    final isModerated =
-        (lastPackage!.isModerated ?? false) || (pv.isModerated ?? false);
+    final isModerated = lastPackage!.isModerated || pv.isModerated;
 
     final objectName = tarballObjectName(pv.package, pv.version!);
     final publicInfo = await publicBucket.tryInfo(objectName);