Minimal check for hook/ files in new uploads. #7847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigurdm
approved these changes
Jul 5, 2024
|
cc @dcharkes |
dcharkes
reviewed
Jul 5, 2024
| @@ -832,3 +833,20 @@ Iterable<ArchiveIssue> checkTopics(String pubspecContent) sync* { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| Iterable<ArchiveIssue> checkHooks(Set<String> fileNames) sync* { | |||
There was a problem hiding this comment.
Should this use the SDK version as @jonasfj suggested in the issue?
There was a problem hiding this comment.
Yeah, if we could pass along the SDK constraint and require that this greater than 3.6.0-0 ensuring that it's at-least Dart 3.6, then I think that'd help a bit.
There was a problem hiding this comment.
@dcharkes we don't know what SDK it'll land in yet, right? Just that it definitely won't be 3.5
jonasfj
approved these changes
Jul 8, 2024
jonasfj
approved these changes
Jul 11, 2024
Co-authored-by: Jonas Finnemann Jensen <jopsen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7541