Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

global activate in dart 3 has issues running previously activated packages #3892

Closed
jonasfj opened this issue Apr 27, 2023 · 2 comments · Fixed by #3897
Closed

global activate in dart 3 has issues running previously activated packages #3892

jonasfj opened this issue Apr 27, 2023 · 2 comments · Fixed by #3897
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@jonasfj
Copy link
Member

jonasfj commented Apr 27, 2023

Reproduce:

dvm install 2.19.6
dvm install 3.0.0-417.3.beta
dvm use 2.19.6
dart pub global deactivate grinder
dart pub global activate grinder
dvm use 3.0.0-417.3.beta
dart pub global activate grinder
dart pub global run grinder

Outputs:

grinder as globally activated doesn't support Dart 3.0.0-417.3.beta, try: dart pub global activate grinder

Expected output:

Error: expected to find 'tool/grind.dart' relative to the current directory.
@jonasfj jonasfj added the type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) label Apr 27, 2023
@jonasfj jonasfj mentioned this issue Apr 27, 2023
Closed
@jonasfj
Copy link
Member Author

jonasfj commented Apr 27, 2023

@sigurdm any ideas? This might be worth cherry-picking a fix for.

@mit-mit
Copy link
Member

mit-mit commented Apr 27, 2023

Confirmed in google/grinder.dart#397 (comment) that deactivate + activate + run is a workaround

@sigurdm sigurdm mentioned this issue Apr 28, 2023
Merged
@sigurdm sigurdm mentioned this issue May 1, 2023
Closed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue May 2, 2023
@sigurdm
Cherry pick to beta of fix of global runfor existing activation
2c7be56 
Bump pub to 3a7dc04eda4e7c359aed35176658bb2acc264f2e

Changes:
```
> git log --format="%C(auto) %h %s" 762a16d..3a7dc04
 https://dart.googlesource.com/pub.git/+/3a7dc04e Reinterpret dart sdk constraints when read from a lockfile (3897)

```

Diff: https://dart.googlesource.com/pub.git/+/762a16d4149b007de4c7cdd0f2798db1ead9eff0..3a7dc04eda4e7c359aed35176658bb2acc264f2e/
Bug: dart-lang/pub#3892
Change-Id: Ie0cc3fced1656c096a377e23eda1d67b9897768d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/300240
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reinterpret dart sdk constraints when read from a lockfile sigurdm/pub
2 participants
@jonasfj @mit-mit