Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pub build - expose other folders, not just web #695

Closed
DartBot opened this issue Jun 5, 2015 · 18 comments
Closed

pub build - expose other folders, not just web #695

DartBot opened this issue Jun 5, 2015 · 18 comments
Assignees
Labels
type-enhancement A request for a change that isn't a bug

Comments

@DartBot
Copy link

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/2049220?v=3" align="left" width="96" height="96"hspace="10"> Issue by sigmundch
Originally opened as dart-lang/sdk#14673


pub build currently will create a 'build/' folder that contains whatever is under 'web/'.

I was wondering if we should make the 'web/' folder explicit, so we can later make room to add 'example/' and 'app/' as other folders generated under 'build/'.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

This comment was originally written by Erik.G...@gmail.com


If I understand Sigmund's issue correctly, this would be useful for people making packages of polymer elements. For example, the polymer-elements library (https://github.com/Polymer/polymer-elements), is a collection of polymer elements with an entry point in example for each element. Also, what if I want to transform and run unit tests in javascript against the javascript version of the code?

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/5479?v=3" align="left" width="48" height="48"hspace="10"> Comment by sethladd


I'd love pub build to work with example/ and bin/ (for server-side apps, the build process is a bit different I presume, but creating a snapshot is a good first step)

@DartBot DartBot added type-enhancement A request for a change that isn't a bug Fixed labels Jun 5, 2015
@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3


I don't think we're likely to want to use "pub build" with example folders or tests; those seem like a better fit with "pub serve", since they don't need to be deployed anywhere.

That leaves "web" and "bin". Most apps aren't going to have both of these directories, so I don't really want to optimize the directory layout for all apps to handle the few apps that do. Maybe once we start supporting server-side building we can split up the subdirectories in that case in particular, though.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/405837?v=3" align="left" width="48" height="48"hspace="10"> Comment by zoechi


Actually I want to publish the examples of my libraries on i.e. Github pages so people can check them out without setting something up by themselves just to see if it contains what they are looking for (polymer elements).

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent


Removed Type-Defect label.
Added Type-Enhancement label.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/2049220?v=3" align="left" width="48" height="48"hspace="10"> Comment by sigmundch


Issue #583 has been merged into this issue.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

This comment was originally written by ross.dart....@gmail.com


I want to build the example/ for library packages to deploy on github pages and I want to build the test/ for library packages so that I might (easily) test the compiled javascript test application (html tests) on drone.io w/ content_shell

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/2192312?v=3" align="left" width="48" height="48"hspace="10"> Comment by keertip


Marked this as blocking dart-lang/sdk#13591.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent


Removed Priority-Unassigned label.
Added Priority-High label.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent


Marked this as blocking dart-lang/sdk#15829.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent


Set owner to @munificent.
Added Accepted label.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3


For reference, this is the current plan for this behavior: https://gist.github.com/munificent/8360674

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent


Added Started label.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3


Issue #828 has been merged into this issue.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/5479?v=3" align="left" width="48" height="48"hspace="10"> Comment by sethladd


Looks like the code was committed. Awesome!


Added this to the 1.2 milestone.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/5479?v=3" align="left" width="48" height="48"hspace="10"> Comment by sethladd


CL: https://codereview.chromium.org/141113011

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent


Added Fixed label.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

This comment was originally written by dev...@futureperfect.info


great news!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

2 participants