More robust snapshot deletion #4170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasfj
approved these changes
Mar 12, 2024
| @@ -455,7 +455,7 @@ To update `$lockFilePath` run `$topLevelProgram pub get`$suffix without | |||
| if (precompile) { | |||
| await precompileExecutables(); | |||
| } else { | |||
| await _deleteExecutableSnapshots(changed: result.changedPackages); | |||
| await _deleteExecutableSnapshots(); | |||
There was a problem hiding this comment.
I guess we are throwing away information here. But at the same time, I don't know how we would communicate to a different compilation process what dependency entries changed.
There was a problem hiding this comment.
To be clear, I'm just making an observation, not saying it's a problem.
I think this is solid! :D
|
Are there potential problems where new/old SDK versions interact poorly here? I think not since snapshots are suffixed with SDK-version. |
If you switch between two different sdk versions you'll have your snapshots deleted all the time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change snapshot deletion to only delete snapshots made by different sdk's.
This is such that the
.dart_toolfolder will not grow without bounds.This requires that we rebuild even snapshots from mutable packages after pub get. So this pr also adds a timestamp check comparing the snapshot modified time to the
.dart_tool/package_config.jsonmodified time. And will recompile if the snapshot is older, even for immutable packages.This is not as bad as it sounds, because we are doing incremental recompilation.
Fixes #4161
pub getanddart runwill still race if they are run concurrently from different sdks. But that seems acceptable.