Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add travis, update FFI for Dart 2.6 #19

Merged
merged 7 commits into from
Nov 5, 2019
Merged

add travis, update FFI for Dart 2.6 #19

merged 7 commits into from
Nov 5, 2019

Conversation

johnpryan
Copy link
Collaborator

  • set up package:mono_repo
  • add test to ffi/hello_world

@johnpryan
add travis
e1dcbb5 
- set up package:mono_repo
- add test to ffi/hello_world
@johnpryan
fix typo
41eb4a4
@johnpryan johnpryan changed the title add travis (Draft) add travis Nov 4, 2019
@johnpryan johnpryan marked this pull request as ready for review November 4, 2019 23:42
domesticmouse
domesticmouse approved these changes Nov 5, 2019
View reviewed changes
Copy link
Member

@domesticmouse domesticmouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we need to elide FFI samples from Dart 2.5 tests.

@johnpryan johnpryan merged commit 3933ad3 into dart-lang:master Nov 5, 2019
@johnpryan johnpryan changed the title (Draft) add travis add travis, update FFI for Dart 2.6 Nov 5, 2019
@johnpryan johnpryan mentioned this pull request Nov 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domesticmouse domesticmouse domesticmouse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johnpryan @domesticmouse