Skip to content

Commit

Permalink
Set --debugger-module-names to true by default in preparation for rem…
Browse files Browse the repository at this point in the history
…oval of the flag

first step for resolving #42104

Change-Id: Ie385e1d014149d67c5223aef698132b67df7ee43
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153949
Reviewed-by: Jonah Williams <jonahwilliams@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Anna Gringauze <annagrin@google.com>
  • Loading branch information
Anna Gringauze authored and commit-bot@chromium.org committed Jul 10, 2020
1 parent c367b48 commit 16e607e
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
2 changes: 1 addition & 1 deletion pkg/frontend_server/lib/frontend_server.dart
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ ArgParser argParser = ArgParser(allowTrailingOptions: true)
..addOption('libraries-spec',
help: 'A path or uri to the libraries specification JSON file')
..addFlag('debugger-module-names',
help: 'Use debugger-friendly modules names', defaultsTo: false)
help: 'Use debugger-friendly modules names', defaultsTo: true)
..addFlag('experimental-emit-debug-metadata',
help: 'Emit module and library metadata for the debugger',
defaultsTo: false)
Expand Down
4 changes: 0 additions & 4 deletions pkg/frontend_server/test/frontend_server_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -1490,7 +1490,6 @@ true
'--output-dill=${dillFile.path}',
'--target=dartdevc',
'--packages=${tempDir.path}/.packages',
'--debugger-module-names'
];

final StreamController<List<int>> streamController =
Expand Down Expand Up @@ -1557,7 +1556,6 @@ true
'--output-dill=${dillFile.path}',
'--target=dartdevc',
'--packages=${tempDir.path}/.packages',
'--debugger-module-names',
'--experimental-emit-debug-metadata'
];

Expand Down Expand Up @@ -1621,7 +1619,6 @@ true
'--output-dill=${dillFile.path}',
'--target=dartdevc',
'--packages=${tempDir.path}/.packages',
'--debugger-module-names'
];

final StreamController<List<int>> streamController =
Expand Down Expand Up @@ -1729,7 +1726,6 @@ true
'--output-dill=${dillFile.path}',
'--target=dartdevc',
'--packages=${tempDir.path}/.packages',
'--debugger-module-names'
];

final StreamController<List<int>> streamController =
Expand Down

0 comments on commit 16e607e

Please sign in to comment.