Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add source-map support for the observable transfomer #12340

Closed
sigmundch opened this issue Aug 9, 2013 · 8 comments
Closed

add source-map support for the observable transfomer #12340

sigmundch opened this issue Aug 9, 2013 · 8 comments
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue

Comments

@sigmundch
Copy link
Member

This is currently

@sigmundch
Copy link
Member Author

(err hit enter too quickly)

This is currently blocked on having support for source-maps or composition in barback (see issue #12339).

Once we have a good way to serve intermediate assets we can then add this to the apply function:

      var filename = path.basename(id.path);
      printer.add('\n//# sourceMappingURL=$filename.map');
      printer.build(url); // where url matches the barback url of the source asset.
      transform.addOutput(
          new Asset.fromString(id.addExtension('.map'), printer.map));

And fix tests accordingly.


Marked this as being blocked by #12339.

@sigmundch
Copy link
Member Author

Added this to the M8 milestone.

@sigmundch
Copy link
Member Author

Removed this from the M8 milestone.
Added this to the Later milestone.

@sigmundch
Copy link
Member Author

Removed this from the Later milestone.
Added this to the M9 milestone.

@clayberg
Copy link

Removed this from the M9 milestone.
Added this to the 1.1 milestone.

@jmesserly
Copy link

I don't think we need to do this any time soon. We're not altering line numbers so debugging should be okay. And we don't transform except when compiling to JS so it generally doesn't matter


Removed this from the 1.1 milestone.
Added this to the Later milestone.
Added NotPlanned label.

@anders-sandholm
Copy link
Contributor

Removed Library-Observe label.
Added Pkg-Observe label.

@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-archive/observe#29.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue
Projects
None yet
Development

No branches or pull requests

5 participants