Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect interceptors on patched elements in Firefox #13190

Closed
blois opened this issue Sep 9, 2013 · 4 comments
Closed

Incorrect interceptors on patched elements in Firefox #13190

blois opened this issue Sep 9, 2013 · 4 comments
Assignees
Milestone

Comments

@blois
Copy link
Contributor

blois commented Sep 9, 2013

With custom elements and the polymer.js polyfill, HTMLElements are getting interceptors for HTMLUnknownElement and breaking interceptor checks for later elements.

Basically unknown custom elements in Firefox are getting their prototype swizzled to HTMLElement, but the toString is still resulting in HTMLUnknownElement, so HTMLElement prototype is getting HTMLUnknownElement's interceptor.

@rakudrama
Copy link
Member

A work-around for this is to call getInterceptor on a known direct instance of HTMLElement.

A fix would be to patch some or all available prototypes a isolate start-up.
This would have the advantage of reducing map transitions in V8.


Added this to the M7 milestone.
Removed Priority-Unassigned label.
Added Priority-Medium label.

@rakudrama
Copy link
Member

Marked this as being blocked by #13218.

@kasperl
Copy link

kasperl commented Oct 2, 2013

Removed this from the M7 milestone.
Added this to the M8 milestone.

@rakudrama
Copy link
Member

Pete, can you verify that pre-patching is working?
You should be able to remove the work-around


Set owner to @blois.
Added Fixed label.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants