Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polymer: missing <script>/noscript in custom element definition not diagnosed #14252

Closed
DartBot opened this issue Oct 20, 2013 · 3 comments
Closed
Labels
closed-duplicate Closed in favor of an existing report

Comments

@DartBot
Copy link

DartBot commented Oct 20, 2013

This issue was originally filed by serg...@chromium.org


A polymer-element definition is supposed to provide either a <script> tag or a 'noscript' attribute. However, when both are missing, no useful diagnostic is output to the console, while the element is broken (doesn't successfully instantiate/render). There should be an error message for this.

@madsager
Copy link
Contributor

Added Area-Polymer, Triaged labels.

@jmesserly
Copy link

A polymer-element definition is supposed to provide either a <script> tag or a 'noscript' attribute.

fyi, Polymer (JS|Dart) supports associating the script after the fact. This is an important scenario because it allows a single script to supply the definitions for multiple custom elements


Added Duplicate label.
Marked as being merged into #14054.

@DartBot
Copy link
Author

DartBot commented Oct 22, 2013

This comment was originally written by serg...@chromium.org


Could this be explicitly indicated by some tag, e.g. 'deferred-script'? This way, if none of 'noscript', 'deferred-script' or <script> was found, an error would be reported.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-duplicate Closed in favor of an existing report
Projects
None yet
Development

No branches or pull requests

4 participants