Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dart2js should generate absolute "file:" URIs in sourcemaps for internal libraries #17544

Closed
nex3 opened this issue Mar 17, 2014 · 5 comments
Closed
Assignees
Labels
closed-duplicate Closed in favor of an existing report needs-info We need additional information from the issue author (auto-closed after 14 days if no response) type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dart2js

Comments

@nex3
Copy link
Member

nex3 commented Mar 17, 2014

When dart2js generates sourcemaps with references to the internal libraries, it produces relative URLs. This breaks on "pub serve", since the internal Dart libraries aren't being served. It should instead generate absolute "file:" URLs.

@nex3
Copy link
Member Author

nex3 commented Mar 17, 2014

Marked this as blocking #17460.

@johnniwinther
Copy link
Member

For which libraries do you need absolute paths?

All libraries?
API internal libraries, i.e. dart:_* libraries?
API libraries, i.e. dart:* libraries?
Package libraries?

Why can't these be served as well?


Set owner to @johnniwinther.
Added NeedsInfo label.

@DartBot
Copy link

DartBot commented Mar 19, 2014

This comment was originally written by @zoechi


As far as my experience with source maps goes
file URIs are only allowed when the entry page was opened using a file URI.
Opening the file from pub serve and loading some additional files from file URI doesn't work.

@nex3
Copy link
Member Author

nex3 commented Mar 19, 2014

We could potentially serve the Dart SDK libraries. Currently it's difficult to communicate to dart2js where the SDK is on the server, though, since it takes and emits paths only in terms of the filesystem.

@nex3 nex3 added Type-Defect web-dart2js needs-info We need additional information from the issue author (auto-closed after 14 days if no response) labels Mar 19, 2014
@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed priority-unassigned labels Feb 29, 2016
@sigmundch sigmundch added the closed-duplicate Closed in favor of an existing report label Jan 18, 2017
@sigmundch
Copy link
Member

combining with #20259

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-duplicate Closed in favor of an existing report needs-info We need additional information from the issue author (auto-closed after 14 days if no response) type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dart2js
Projects
None yet
Development

No branches or pull requests

5 participants