Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better messaging for pause on isolate events #18692

Closed
keertip opened this issue May 7, 2014 · 11 comments
Closed

Better messaging for pause on isolate events #18692

keertip opened this issue May 7, 2014 · 11 comments
Assignees
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures type-enhancement A request for a change that isn't a bug
Milestone

Comments

@keertip
Copy link
Contributor

keertip commented May 7, 2014

Right now Editor users have no indication that the application has paused and they should switch to the observatory to continue. For a start, it would be fine to print to stdout indicating the event and the url to reach the observatory.

@johnmccutchan
Copy link
Contributor

Marked this as blocking #18358.

@kasperl
Copy link

kasperl commented May 8, 2014

Removed this from the 1.4 milestone.
Added this to the 1.5 milestone.

@kevmoo
Copy link
Member

kevmoo commented Jun 5, 2014

Removing the Milestone 1.5 flag. Please yell loudly this is critical for 1.5.


cc @keertip.
Removed this from the 1.5 milestone.

@iposva-google
Copy link
Contributor

Printing to stdout will change the program's behaviour. So that is not an option.

The editor can make an observatory request and verify whether the isolate is running or paused showing an indication if that is desired.


cc @johnmccutchan.
Removed the owner.
Removed Area-Observatory label.
Added Area-Editor label.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Added this to the 1.6 milestone.

@clayberg
Copy link

Set owner to @keertip.
Removed Type-Defect label.
Added Type-Enhancement label.

@keertip
Copy link
Contributor Author

keertip commented Jul 11, 2014

John,

The editor is using the --trace_service_pause_events when starting the observatory. I see a message in the console like the one below for pause isolates on exit, but not for pause isolates on start. Is the editor missing the message or does the observatory not show it?

Isolate sample.dart$main-518862436 paused before exiting. Use the Observatory to release it.

@johnmccutchan
Copy link
Contributor

Hi,

We don't display any message when paused on start. We probably shouldn't print anything but have the editor poll over the VM service for status changes in isolates- it's really simple and could provide a better user experience.

John

@keertip
Copy link
Contributor Author

keertip commented Jul 11, 2014

What would this involve? And how would the editor use the status info to provide a better user experience?

@johnmccutchan
Copy link
Contributor

Hi,

It would involve polling (with an HTTP request) the service port checking on the status of isolates. It's possible to tell if an isolate is blocked before starting or blocked from exiting (among many other things). I'm no UI/UX expert though it just seems better to have the Editor actually know what's going on and surface that data to the user in a way other than having it show up console output. Possibly, the better UI would be to bring up a dialog box or modify the debugger tool to reflect this state. I think burying this in the console output isn't very discoverable.

@keertip
Copy link
Contributor Author

keertip commented Jul 15, 2014

The polling looks like a bit of work for the editor. For now will go with adding a message to indicate pause on start. And we have a message to indicate pause before exit.

https://codereview.chromium.org/387283002/


Added Fixed label.

@keertip keertip added Type-Enhancement P1 A high priority bug; for example, a single project is unusable or has many test failures labels Jul 15, 2014
@keertip keertip self-assigned this Jul 15, 2014
@keertip keertip added this to the 1.6 milestone Jul 15, 2014
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

6 participants