Some angular and webcomponent tests started failing on dart2js-drt #19329

karlklose · 2014-06-10T09:33:37Z

From the error messages it looks like applyAuthorStyles is no longer supported and these tests use it.

Failing tests:
third_party/angular_tests/browser_test/core_dom/compiler
third_party/angular_tests/browser_test/core_dom/shadow_root_options
third_party/angular_tests/browser_test/core/templateurl
web_components/test/interop2_test

Logs:
http://chromegw.corp.google.com/i/client.dart/builders/dart2js-drt-linux-csp-be/builds/1352/steps/annotated_steps/logs/stdio

http://chromegw.corp.google.com/i/client.dart/builders/dart2js-drt-linux-1-2-be/builds/2532/steps/annotated_steps/logs/stdio

sigmundch · 2014-06-10T23:45:25Z

Thanks for letting me know about the web_components test. I did a few status updates and deleted interop2_test last night. I think those changes were not included in that run of the bots. I think they are sorted out now (a later run of the csp bot seems to show those tests green).

Jacob also submitted a change that, instead of deleting applyAuthorStyle, it added a default implementation with a deprecated message. I believe that shuold've fixed the angular failures.

cc @jacob314.

kasperl · 2014-06-11T08:55:54Z

Any more details about Jacob's fix for applyAuthorStyle? We're seeing failures on the trunk builders too.

kasperl · 2014-06-11T12:09:46Z

Added Area-Library, Library-Html, Triaged labels.

sigmundch · 2014-06-11T19:08:28Z

The change from Jacob was https://code.google.com/p/dart/source/detail?r=37154

kasperl · 2014-06-11T19:13:32Z

As far as I can tell we already merged r37154 to trunk (in r37161), but maybe we should double check that. We are still seeing the shadow_root_options test failure on trunk; see http://build.chromium.org/p/client.dart/builders/dart2js-drt-linux-1-2-dev/builds/159/steps/dart2js-drt%20tests/logs/stdio:

FAILED: dart2js-drt release_ia32 pkg/third_party/angular_tests/browser_test/core_dom/shadow_root_options
Expected: Pass Slow
Actual: RuntimeError
CommandOutput[dart2js]:

stdout:
third_party/pkg/angular/test/filter/order_by_spec.dart:10:12:
Hint: The class 'Name' overrides 'operator==', but not 'get hashCode'.
  operator ==(Name other) =>
           ^^
third_party/pkg/angular/test/filter/filter_spec.dart:9:39:
Hint: Using 'new Symbol' may lead to unnecessarily large generated code.
Try using 'const Symbol' or adding '@MirrorsUsed(...)' as described at https://goo.gl/Akrrog.
    init.forEach((key, value) => map[new Symbol(key)] = value);
                                      ^^^
third_party/pkg/angular/test/directive/input_select_spec.dart:98:9:
Warning: No operator '[]' in class 'ElementList'.
        .rootElement.querySelectorAll('option')[0].selected = true;
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Hint: 4 hint(s) suppressed in package:di.
Hint: 1 warning(s) suppressed in dart:_js_mirrors.
Hint: 1 hint(s) suppressed in package:mock.
Hint: 1 warning(s) and 4 hint(s) suppressed in package:angular.
pkg/third_party/angular_tests/browser_test.dart:
Hint: 8199 methods retained for use by dart:mirrors out of 14224 total methods (58%).

out/ReleaseIA32/packages/angular/angular.dart:52:1:
Info: This import is not annotated with @MirrorsUsed, which may lead to unnecessarily large generated code.
Try adding '@MirrorsUsed(...)' as described at https://goo.gl/Akrrog.
import 'dart:mirrors' show MirrorsUsed;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
out/ReleaseIA32/packages/di/mirrors.dart:3:1:
Info: This import is not annotated with @MirrorsUsed, which may lead to unnecessarily large generated code.
Try adding '@MirrorsUsed(...)' as described at https://goo.gl/Akrrog.
import 'dart:mirrors';
^^^^^^^^^^^^^^^^^^^^^^
out/ReleaseIA32/packages/di/reflected_type.dart:7:1:
Info: This import is not annotated with @MirrorsUsed, which may lead to unnecessarily large generated code.
Try adding '@MirrorsUsed(...)' as described at https://goo.gl/Akrrog.
import 'dart:mirrors';
^^^^^^^^^^^^^^^^^^^^^^
out/ReleaseIA32/packages/angular/core/module.dart:5:1:
Info: This import is not annotated with @MirrorsUsed, which may lead to unnecessarily large generated code.
Try adding '@MirrorsUsed(...)' as described at https://goo.gl/Akrrog.
import 'dart:mirrors';
^^^^^^^^^^^^^^^^^^^^^^
out/ReleaseIA32/packages/angular/core/parser/eval_access.dart:3:1:
Info: This import is not annotated with @MirrorsUsed, which may lead to unnecessarily large generated code.
Try adding '@MirrorsUsed(...)' as described at https://goo.gl/Akrrog.
import 'dart:mirrors';
^^^^^^^^^^^^^^^^^^^^^^
out/ReleaseIA32/packages/angular/core/parser/eval_calls.dart:3:1:
Info: This import is not annotated with @MirrorsUsed, which may lead to unnecessarily large generated code.
Try adding '@MirrorsUsed(...)' as described at https://goo.gl/Akrrog.
import 'dart:mirrors';
^^^^^^^^^^^^^^^^^^^^^^
out/ReleaseIA32/packages/angular/change_detection/watch_group.dart:3:1:
Info: This import is not annotated with @MirrorsUsed, which may lead to unnecessarily large generated code.
Try adding '@MirrorsUsed(...)' as described at https://goo.gl/Akrrog.
import 'dart:mirrors';
^^^^^^^^^^^^^^^^^^^^^^
out/ReleaseIA32/packages/angular/change_detection/dirty_checking_change_detector.dart:3:1:
Info: This import is not annotated with @MirrorsUsed, which may lead to unnecessarily large generated code.
Try adding '@MirrorsUsed(...)' as described at https://goo.gl/Akrrog.
import 'dart:mirrors';
^^^^^^^^^^^^^^^^^^^^^^
out/ReleaseIA32/packages/angular/core_dom/module.dart:6:1:
Info: This import is not annotated with @MirrorsUsed, which may lead to unnecessarily large generated code.
Try adding '@MirrorsUsed(...)' as described at https://goo.gl/Akrrog.
import 'dart:mirrors';
^^^^^^^^^^^^^^^^^^^^^^
out/ReleaseIA32/packages/mock/src/mock.dart:9:1:
Info: This import is not annotated with @MirrorsUsed, which may lead to unnecessarily large generated code.
Try adding '@MirrorsUsed(...)' as described at https://goo.gl/Akrrog.
import 'dart:mirrors';
^^^^^^^^^^^^^^^^^^^^^^

CommandOutput[content_shell]:

stdout:
#READY
CONSOLE MESSAGE: line 78: {
  "type": "debug",
  "value": "test_controller.js started",
  "timestamp": 0
}
CONSOLE WARNING: line 7: <script src="packages/browser/interop.js"> is no longer needed for dart:js. See http://pub.dartlang.org/packages/browser.
CONSOLE MESSAGE: line 78: {
  "type": "print",
  "value": "dart-calling-main",
  "timestamp": 5.031
}
CONSOLE MESSAGE: line 78: {
  "type": "print",
  "value": "dart-main-done",
  "timestamp": 5.628
}
CONSOLE MESSAGE: line 78: {
  "type": "message_received",
  "value": "dart-calling-main",
  "timestamp": 5.635
}
CONSOLE MESSAGE: line 78: {
  "type": "message_received",
  "value": "unittest-suite-wait-for-done",
  "timestamp": 5.636
}
CONSOLE WARNING: line 99824: ShadowRoot.resetStyleInheritance and ShadowRoot.applyAuthorStyles now deprecated in dart:html.
Please remove them from your code.

cc @ricowind.

karlklose · 2014-06-13T16:46:29Z

pkg/web_components/test/interop_test started failing on drt, too.

whesse · 2014-08-04T08:19:55Z

Only two of these tests are still failing:

third_party/angular_tests/browser_test/core_dom/shadow_root_options

and

web_components/test/interop_test, which is only failing on --csp dart2js, due to a security policy violation: Refused to evaluate a string as JavaScript because 'unsafe-eval' is not an allowed source of script in the following Content Security Policy directive: "script-src 'self'".

sigmundch · 2014-08-04T19:41:46Z

btw - we can change the test to move the inline code into a separate .js file to get rid of the CSP violation.

matanlurey · 2018-06-19T00:05:25Z

I'm guessing we no longer care about this.

karlklose added Type-Defect area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-html labels Aug 4, 2014

kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed priority-unassigned labels Mar 1, 2016

whesse mentioned this issue Oct 12, 2017

js_interop test failing with content security policy (csp) on dart2js #31082

Open

matanlurey added the closed-obsolete Closed as the reported issue is no longer relevant label Jun 19, 2018

matanlurey closed this as completed Jun 19, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Some angular and webcomponent tests started failing on dart2js-drt #19329

Some angular and webcomponent tests started failing on dart2js-drt #19329

karlklose commented Jun 10, 2014

sigmundch commented Jun 10, 2014

kasperl commented Jun 11, 2014

kasperl commented Jun 11, 2014

sigmundch commented Jun 11, 2014

kasperl commented Jun 11, 2014

karlklose commented Jun 13, 2014

whesse commented Aug 4, 2014

sigmundch commented Aug 4, 2014

matanlurey commented Jun 19, 2018

Some angular and webcomponent tests started failing on dart2js-drt #19329

Some angular and webcomponent tests started failing on dart2js-drt #19329

Comments

karlklose commented Jun 10, 2014

sigmundch commented Jun 10, 2014

kasperl commented Jun 11, 2014

kasperl commented Jun 11, 2014

sigmundch commented Jun 11, 2014

kasperl commented Jun 11, 2014

karlklose commented Jun 13, 2014

whesse commented Aug 4, 2014

sigmundch commented Aug 4, 2014

matanlurey commented Jun 19, 2018