Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dart2js - extended td shows nothing in other browsers #21466

Closed
DartBot opened this issue Oct 30, 2014 · 6 comments
Closed

dart2js - extended td shows nothing in other browsers #21466

DartBot opened this issue Oct 30, 2014 · 6 comments
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams.

Comments

@DartBot
Copy link

DartBot commented Oct 30, 2014

This issue was originally filed by roman.b...@gmail.com


What steps will reproduce the problem?

http://pastebin.com/2EqxcvUQ
Here is the Code to reproduce the Problem

What is the expected outcome?
We build a table with some functions and everything worked fine in Dartium/Chrome. Then we noticed that FF/IE show nothing of the table. So we tried finding the error. Apparently the import of the extended td element causes this.


Attachments:
e1.png (68.44 KB)
e2.png (67.09 KB)

@peter-ahe-google
Copy link
Contributor

Sorry for not replying sooner to this bug report. Unfortunately, it was filed under the "Try Dart" area and I failed to assign it to dart2js sooner.


Removed Area-TryDart label.
Added Area-Dart2JS label.

@floitschG
Copy link
Contributor

Looks like a Polymer issue.
My debugging findings:

Inside _registerCustomElement there is a check that document.createElement(extendsTagName) instanceof window[baseClassName].

The fields are:
extendsTagName: "td".
baseClassName: "HTMLTableCellElement"

The object returned from document.createElement(extendsTagName) has it's proto set to a GeneratedWrapper.


Removed Area-Dart2JS label.
Added Area-Pkg, Pkg-Polymer labels.

@jakemac53
Copy link
Contributor

Submitted a bug to the js polyfills about this, webcomponents/webcomponentsjs#80. It looks like this is actually related to a browser bug, so there aren't any good options to fix this that I know of at this time :(.

@DartBot
Copy link
Author

DartBot commented Dec 2, 2014

This comment was originally written by roman.balzer...@gmail.com


Since extended tds did not work for me i remove the inheritance from td and just used it as a normal polymer element with display: table-cell.

Next problem was that my polymer table row does extend from tr.
-> FF didnt show the table row
I think extended th had the same problem, but i'm not sure since i dont use it anymore.

Sadly I had to remove all Inheritance from td / tr / th.

@sigmundch
Copy link
Member

Unfortunately there are a lot of issues with extending table elements because of limitations on how browsers parse tables and what is allowed or not inside tables by the HTML5 spec :-(

See for example another related problem with tr: Polymer/polymer#266

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

This issue has been moved to dart-archive/polymer-dart#334.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams.
Projects
None yet
Development

No branches or pull requests

6 participants