Analyzer complains about switch statements

[DartBot]

This issue was originally filed by briangepper...@briangeppert.com

---

What steps will reproduce the problem?

1. Write a multi-branch switch statement, like the following:

  void toggle() {
    switch(this.state) {
      case 'play': {
        this.state = this.pauseDisabled ? 'stop' : 'pause';
        break;
      }
      case 'pause': {
        this.state = 'stop';
        break;
      }
      case 'stop': {
        this.state = 'play';
        break;
      }
    }
  }

1. Analyzer complains about the first two branches not ending in a 'break', 'continue', 'return' or 'throw' statement.

What is the expected output? What do you see instead?

I'd expect the analyzer to detect that each branch ends in a 'break'. It does not.

What version of the product are you using?

Chrome Dev Editor (0.18.3450).

On what operating system?

Windows 8.

What browser (if applicable)?

Chrome 39.

[bwilkerson]

According to the specification:

It is a static warning if the last statement of the statement sequence sk is not a
break, continue, return or throw statement.

Unforunately, the last statement is a block, not one of the listed statements.

Any chance of changing the specification to include (a) a rethrow statement and/or (b) a block whose last statement is one of the listed kinds of statements?

---

Set owner to @gbracha.
Added Area-Language, Triaged labels.

[srawlins]

@gbracha This is fixed now, right? The spec now states:

If s is a non-empty block statement, let s instead be the last statement of the block statement.

[munificent]

Yep!