Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chrome 47 removes initHashChangeEvent, need to stop calling it #25158

Closed
alan-knight opened this issue Dec 7, 2015 · 0 comments
Closed

Chrome 47 removes initHashChangeEvent, need to stop calling it #25158

alan-knight opened this issue Dec 7, 2015 · 0 comments
Labels
library-html P1 A high priority bug; for example, a single project is unusable or has many test failures web-libraries Issues impacting dart:html, etc., libraries
Milestone
1.14

Comments

@alan-knight
Copy link
Contributor

We call initHashChangeEvent in HashChangeEvent's constructor, because it's in the darttemplate file. That no longer exists in Chrome. We can remove it if all browsers now use the constructor, otherwise we need to check which one we're to call.
@alan-knight alan-knight added P1 A high priority bug; for example, a single project is unusable or has many test failures web-libraries Issues impacting dart:html, etc., libraries library-html labels Dec 7, 2015
@alan-knight alan-knight added this to the 1.14 milestone Dec 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
library-html P1 A high priority bug; for example, a single project is unusable or has many test failures web-libraries Issues impacting dart:html, etc., libraries
Projects
None yet
Milestone
1.14
Development

No branches or pull requests
1 participant
@alan-knight