Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dartium crashes if Dart app is inside iframe #26117

Closed
daniel-v opened this issue Mar 29, 2016 · 20 comments
Closed

Dartium crashes if Dart app is inside iframe #26117

daniel-v opened this issue Mar 29, 2016 · 20 comments
Assignees
@terrylucas
Milestone
1.18

Comments

@daniel-v
Copy link

Description:

Dartium crashes if an application is in an iframe and a debugger breakpoint is placed anywhere in the code of that "iframed" application.

Affected versions

  • Version 45.0.2454.0 64 and 32 bit versions

Version 39.0.2171.0 (64-bit) worked. (1.13.0 dart version)

Reproduction:

Have these 2 HTML files and dart file:

<!-- index.html -->
<html><body>
<iframe src="dartapp.html"></iframe>                                                                                                     
</body></html>
<!-- dartapp.html -->
<html><body>
<script src="dartapp.dart" type="application/dart"></script>
</body></html>
// dartapp.dart
main() {
  print("I crash if you put a breakpoint on me");
}
@goderbauer
Copy link
Contributor

Are there any plans to fix this?

@terrylucas terrylucas added this to the 1.17 milestone Apr 28, 2016
@terrylucas terrylucas self-assigned this Apr 28, 2016
@terrylucas
Copy link
Contributor

I'll take a look.

@goderbauer
Copy link
Contributor

Thank you. Much appreciated.

@nex3
Copy link
Member

nex3 commented Apr 28, 2016

If we could get a fix for this merged into stable, that would be great. It pretty much totally breaks users' ability to debug their tests using the test package.

@daniel-v
Copy link
Author

daniel-v commented Apr 29, 2016 •
edited

@terrylucas Thanks for taking a look.

I too would like to see this in stable, for a good while now, I cannot debug in Dartium.

@floitschG
Copy link
Contributor

/cc @mit-mit

@mit-mit
Copy link
Member

mit-mit commented May 27, 2016 •
edited

@terrylucas we need a fix in the next few days if this is to make it into the planned final 1.17 stable build next week.

@mit-mit
Copy link
Member

mit-mit commented May 27, 2016

CC @whesse

@terrylucas
Copy link
Contributor

I have been heads down in code yellow I'll take a look today and talk to Jacob about possible solutions.

@terrylucas
Copy link
Contributor

I've narrowed the problem down to the devToolsAgentClient not being set up properly in frame other than the main frame. Looking at a couple of possible solutions.

The problem has existed since 1.16

@terrylucas
Copy link
Contributor

Meant to say since rolling to Chrome 45.

@kevmoo
Copy link
Member

kevmoo commented Jun 1, 2016

FYI: it looks like this happens in Dart 1.15, too.

Confirmed it does work in Dart 1.14.2.

We should fix this, but it is not blocking for 1.17 – it's been around for 2 releases.

@kevmoo kevmoo modified the milestones: 1.18, 1.17 Jun 1, 2016
@mit-mit
Copy link
Member

mit-mit commented Jun 1, 2016

Agree, it's not blocking the 1.17.0 release, but we could do a 1.17.1 patch release if needed. @daniel-v, @goderbauer can you elaborate on the need to get a stable patch for this?

@daniel-v
Copy link
Author

daniel-v commented Jun 1, 2016 •
edited

@mit-mit sure. We consider this a high-impact issue as it slows down our development cycle significantly.
It takes about 7 minutes to compile our Dart application on the dev's machines so that they can debug in Chrome with some source map's available.

So if the question is if we need it: we do, very much so!

@kevmoo you are right, it's been around for 2 releases and I am very hopeful that it won't be in the next one.

Thank you from: Easyling

@kevmoo
Copy link
Member

kevmoo commented Jun 1, 2016

@daniel-v to be 100% clear.

We absolutely consider this critical. We will make all efforts to get a patch out as 1.17.1 or similar.

This is just how we handle bookkeeping for major releases.

1.17 is broken, but no more broken than 1.15.2 wrt this issue.

Thank you much for your patience here.

@kevmoo kevmoo added S0 critical and removed S1 high labels Jun 1, 2016
@daniel-v
Copy link
Author

daniel-v commented Jun 1, 2016

@kevmoo thanks for clearing it up and for the insight into your bookkeeping process.

I am happy with 1.17.1 or similar. :)

@terrylucas
Copy link
Contributor

Have a fix CL sent out a build of Dartium to get banged on to make sure it works for more complex iFrame debugging.

@terrylucas
Copy link
Contributor

Confirmed fixed (in private build) from Michael Goderbauer.

@kevmoo
Copy link
Member

kevmoo commented Jun 2, 2016

Confirmed fixed in Dart VM version: 1.17.0-dev.6.1 - mac.

Thanks, @terrylucas !

@kevmoo
Copy link
Member

kevmoo commented Jun 2, 2016

Resolved in 5a9b600 - master
Resolved in 25b5232 - v1.17 dev branch

@mit-mit mit-mit mentioned this issue Jun 2, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terrylucas terrylucas

Labels
None yet
Projects
None yet
Milestone
1.18
Development

No branches or pull requests
8 participants
@nex3 @kevmoo @goderbauer @sgjesse @terrylucas @daniel-v @floitschG @mit-mit