deprecate execution.setSubscriptions #28806

Closed
devoncarew opened this Issue Feb 17, 2017 · 5 comments

Projects

None yet

3 participants

@devoncarew
Member

I see this exception:

Bad state: Should not be used with the new analysis driver, stackTrace:
  #0      ContextManagerImpl.folderMap (package:analysis_server/src/context_manager.dart:561:7)
  #1      ContextManagerImpl.analysisContexts (package:analysis_server/src/context_manager.dart:557:53)
  #2      AnalysisServer.analysisContexts (package:analysis_server/src/analysis_server.dart:434:22)
  #3      ExecutionDomainHandler._reportCurrentFileStatus (package:analysis_server/src/domain_execution.dart:218:44)
  #4      ExecutionDomainHandler.setSubscriptions (package:analysis_server/src/domain_execution.dart:167:9)
@devoncarew
Member

IntelliJ, atom, and vscode don't use this server request. The only client I can find that uses it is the older Eclipse client. One option here - if implementation is not straightforward - it to deprecate the API call and change the implementation into a no-op.

@scheglov @bwilkerson

@scheglov
Contributor

My vote is to remove it altogether.
It does not have clients, and any service that requires analysis of all files is expensive.

@bwilkerson
Member

I would prefer to deprecate it. Removing it is a breaking change and I'd like to minimize the number of breaking change versions of the server protocol.

@bwilkerson bwilkerson added the P3 low label Feb 21, 2017
@devoncarew devoncarew changed the title from execution.setSubscriptions not implemented with the new driver to deprecate execution.setSubscriptions Feb 21, 2017
@devoncarew
Member

I re-purposed this issue to one for deprecating execution.setSubscriptions.

@devoncarew devoncarew added P2 medium and removed P3 low labels Feb 23, 2017
@devoncarew
Member

(done)

@devoncarew devoncarew closed this Feb 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment