Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate execution.setSubscriptions #28806

Closed
devoncarew opened this issue Feb 17, 2017 · 5 comments
Closed

deprecate execution.setSubscriptions #28806

devoncarew opened this issue Feb 17, 2017 · 5 comments
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on

Comments

@devoncarew
Copy link
Member

I see this exception:

Bad state: Should not be used with the new analysis driver, stackTrace:
  #0      ContextManagerImpl.folderMap (package:analysis_server/src/context_manager.dart:561:7)
  #1      ContextManagerImpl.analysisContexts (package:analysis_server/src/context_manager.dart:557:53)
  #2      AnalysisServer.analysisContexts (package:analysis_server/src/analysis_server.dart:434:22)
  #3      ExecutionDomainHandler._reportCurrentFileStatus (package:analysis_server/src/domain_execution.dart:218:44)
  #4      ExecutionDomainHandler.setSubscriptions (package:analysis_server/src/domain_execution.dart:167:9)
@devoncarew devoncarew added analyzer-new-driver area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. labels Feb 17, 2017
@devoncarew
Copy link
Member Author

IntelliJ, atom, and vscode don't use this server request. The only client I can find that uses it is the older Eclipse client. One option here - if implementation is not straightforward - it to deprecate the API call and change the implementation into a no-op.

@scheglov @bwilkerson

@scheglov
Copy link
Contributor

My vote is to remove it altogether.
It does not have clients, and any service that requires analysis of all files is expensive.

@bwilkerson
Copy link
Member

I would prefer to deprecate it. Removing it is a breaking change and I'd like to minimize the number of breaking change versions of the server protocol.

@bwilkerson bwilkerson added the P3 A lower priority bug or feature request label Feb 21, 2017
@devoncarew devoncarew changed the title execution.setSubscriptions not implemented with the new driver deprecate execution.setSubscriptions Feb 21, 2017
@devoncarew
Copy link
Member Author

I re-purposed this issue to one for deprecating execution.setSubscriptions.

@devoncarew devoncarew added P2 A bug or feature request we're likely to work on and removed P3 A lower priority bug or feature request labels Feb 23, 2017
@devoncarew
Copy link
Member Author

(done)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on
Projects
None yet
Development

No branches or pull requests

3 participants