Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VM: The loader's extension of Dart_LibraryTag invokes undefined behavior #28863

Open
rmacnak-google opened this issue Feb 22, 2017 · 1 comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends.

Comments

@rmacnak-google
Copy link
Contributor

The loader uses values for Dart_LibraryTag that aren't declared in the enum in dart_api.h. Using such values is undefined behavior.

@johnmccutchan
Copy link
Contributor

I'm not sure I understand the issue here. The tag handler defines a set of operations and for convenience the service isolate's loader uses the same tag values as the tag handler but then adds more loader-specific tag values. These loader-specific tag values are never seen by the tag handler.

@anders-sandholm anders-sandholm added the area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. label Feb 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends.
Projects
None yet
Development

No branches or pull requests

3 participants