Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ALPN on MacOS again #29240

Closed
mkustermann opened this issue Apr 4, 2017 · 3 comments
Closed

Support for ALPN on MacOS again #29240

mkustermann opened this issue Apr 4, 2017 · 3 comments
Assignees
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. library-io os-osx type-enhancement A request for a change that isn't a bug

Comments

@mkustermann
Copy link
Member

The dart:io implementation had support for ALPN on all platforms since around 1.8.0 but the switch to SecureTransport API removed that functionality on MacOS in version 1.16.0.

ALPN support is necessary for building http/2 and gRPC libraries in Dart, so it would be nice if we could get this functionality working again somehow.

Let's keep this as a tracking bug other issues can refer to.

@mkustermann mkustermann added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. library-io labels Apr 4, 2017
@zanderso zanderso added type-enhancement A request for a change that isn't a bug os-osx labels Apr 4, 2017
@zanderso
Copy link
Member

zanderso commented Jun 7, 2017

Ben has landed support in 644862b, which switches to BoringSSL and uses the system keystore for trusted root certs on Mac, (and does a lot of other great refactoring as well!)

@bkonyi I think we can probably close this issue after updating the changelog and removing/deprecating the alpnSupported flag.

/cc @kevmoo @jakobr-google @kasperl

@zanderso
Copy link
Member

zanderso commented Jun 7, 2017

This should hopefully help unblock #22655 on Mac.

@mkustermann
Copy link
Member Author

This is great, @bkonyi. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. library-io os-osx type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

3 participants