Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling Element.classes.removAll(['something']) blows up with DDC #30278

Closed
kevmoo opened this issue Jul 27, 2017 · 4 comments
Closed

Calling Element.classes.removAll(['something']) blows up with DDC #30278

kevmoo opened this issue Jul 27, 2017 · 4 comments
Assignees
@terrylucas
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures web-dev-compiler web-libraries Issues impacting dart:html, etc., libraries

Comments

@kevmoo
Copy link
Member

kevmoo commented Jul 27, 2017

Sample...

var para = querySelector('p') as ParagraphElement;
print(para);
para.classes.removeAll(['a', 'b']);
@kevmoo
Copy link
Member Author

kevmoo commented Jul 27, 2017

screen shot 2017-07-26 at 8 43 53 pm

screen shot 2017-07-26 at 8 44 04 pm

screen shot 2017-07-26 at 8 44 21 pm

@kevmoo
Copy link
Member Author

kevmoo commented Jul 27, 2017 •
edited by srawlins
Loading

Guessing this is the problem -

sdk/tools/dom/src/dart2js_CssClassSet.dart

Line 196 in 119b2d5

static void _removeAll(Element _element, Iterable<String> iterable) {

Should be Iterable<Object> to match signature of Set.removeAll

@kevmoo kevmoo added web-libraries Issues impacting dart:html, etc., libraries web-dev-compiler S1 high labels Jul 27, 2017
@munificent munificent added P1 A high priority bug; for example, a single project is unusable or has many test failures and removed S1 high labels Jun 21, 2018
@terrylucas
Copy link
Contributor

terrylucas commented Jan 8, 2019 •
edited
Loading

Fixed because Set's removeAll is Iterable<Object> not like addAll Iterable<E> (probably for backward compat) I've change removeAll (signature inside of dart:html) to match Set's Iterable<Object>. Fixes the problem. CL pending plus added test.

@terrylucas
Copy link
Contributor

Fix in CL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terrylucas terrylucas

Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures web-dev-compiler web-libraries Issues impacting dart:html, etc., libraries
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kevmoo @munificent @terrylucas