Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve API docs for List.of, List.from #32959

Open
lexaknyazev opened this issue Apr 24, 2018 · 3 comments
Open

Improve API docs for List.of, List.from #32959

lexaknyazev opened this issue Apr 24, 2018 · 3 comments
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-core type-documentation A request to add or improve documentation

Comments

@lexaknyazev
Copy link
Contributor

Forking this from dart-lang/site-www#736.

Current API descriptions for List.from and List.of aren't sound enough to get the semantic difference between them and their expected use-cases. Please see the discussion starting from this comment.

/cc @munificent
@kevmoo kevmoo added area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. type-documentation A request to add or improve documentation library-core labels Apr 24, 2018
@mnordine
Copy link
Contributor

mnordine commented Sep 3, 2018

Agreed, I'm reading the docs and I have NO IDEA what to use, and why they both exist.

@krisgiesing
Copy link

krisgiesing commented Aug 2, 2019 •
edited

This also applies to Map.of and Map.from, as well as Set.of and Set.from.

@lexaknyazev
Copy link
Contributor Author

An in-depth explanation of the difference is here: #45840 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-core type-documentation A request to add or improve documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kevmoo @mnordine @lexaknyazev @krisgiesing