Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation Issue for Super Mixins: Dart2JS #34168

Closed
JekCharlsonYu opened this issue Aug 16, 2018 · 3 comments
Closed

Implementation Issue for Super Mixins: Dart2JS #34168

JekCharlsonYu opened this issue Aug 16, 2018 · 3 comments
Assignees
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures web-dart2js
Milestone

Comments

@JekCharlsonYu
Copy link
Contributor

JekCharlsonYu commented Aug 16, 2018

What: Issue for implementation for Dart2JS

ETA: 10/15 in Dart Repo.

For: SuperMixins Implementation and strawman documentation

Meta Issue: This is subsumed under the Super Mixins Meta Issue in the Language Repo

Comments: Feel free to break this further into further tasks and issues, or use as a meta issue for all the tasks in the implementation plan

@JekCharlsonYu JekCharlsonYu added P1 A high priority bug; for example, a single project is unusable or has many test failures web-dart2js labels Aug 16, 2018
@JekCharlsonYu JekCharlsonYu added this to the Dart2.1 milestone Aug 16, 2018
@sigmundch
Copy link
Member

Implementation landed. There appears to be a few tests still failing, most due to CFE issues, but a couple that might require changes in the dart2js implementation.

Johnni, could you take a look at those 2 tests (see https://dart-review.googlesource.com/c/sdk/+/77012)?

@vsmenon
Copy link
Member

vsmenon commented Oct 1, 2018

Any updates here?

@sigmundch
Copy link
Member

the last 2 tests were fixed on friday, only remaining work is static errors from the CFE. I believe we can mark this as closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures web-dart2js
Projects
None yet
Development

No branches or pull requests

4 participants