Export functionality used in Flutter Engine to public headers

[mehmetf]

Currently, Flutter engine is using the following private Dart headers:

#include "third_party/dart/runtime/bin/crypto.h"
#include "third_party/dart/runtime/bin/io_natives.h"
#include "third_party/dart/runtime/bin/embedded_dart_io.h"

Please migrate the functionality used by https://github.com/flutter/engine/blob/master/lib/io/dart_io.cc and by https://github.com/flutter/engine/blob/master/lib/ui/dart_runtime_hooks.cc to common Dart headers so these can be converted to third_party/dart/runtime/include/ paths.

This prevents Flutter engine from being compiled in Google.

[mehmetf]

@zanderso @mraleph FYI

[zanderso]

@a-siva This is the header file issue we discussed.

@mehmetf @keertip would it work for you if we captured the needed API in a public header under runtime/bin/include ?

[mehmetf]

Hm, I will leave the final answer up to @keertip however the way we recommend these headers be used now is:

#include <dartapi.h>

which implies there's a collision possibility if we start including files from different dirs.

[a-siva]

You mean 'include <dart_api.h> ?

This include file should probably be called something else, maybe 'dart_embedder_api.h'

[chinmaygarde]

What is the utility of dart_embedder_api.h over dart_api.h? Are they same?

[mehmetf]

I just wanted to highlight that this is blocking an active project. It would be great to get a timeline on this fix. Is it something doable in the next week or so?

[a-siva]

Ben is slated to start work on this, we are in the process of scoping the work and will update with a timeline here.

[bkonyi]

This change landed last week in this CL.