New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some co19_2 tests of experimental features failing on dart2js #35614

Closed
whesse opened this Issue Jan 9, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@whesse
Copy link
Member

whesse commented Jan 9, 2019

The // SharedOptions=
annotation is now processed (obeyed) in co19_2 tests as well, and some
tests of experimental features have started failing now, on dart2js.
See CL https://dart-review.googlesource.com/c/sdk/+/88704

These are using the --enable-experiment=constant-update-2018 flag and the
--enable-experiment=set-literals flag.

They are preapproved, in order to land the change enabling all test annotations on co19 tests,
but should be investigated and fixed.

co19_2/LanguageFeatures/Constant_update2018/EqualityOperator_A01_t01 broke (Pass -> CompileTimeError, expected Pass)
co19_2/LanguageFeatures/Constant_update2018/EqualityOperator_A01_t02 broke (Pass -> CompileTimeError, expected Pass)
co19_2/LanguageFeatures/Constant_update2018/ShortCircuitOperators_A03_t02 broke (Pass -> CompileTimeError, expected Pass)
co19_2/LanguageFeatures/Constant_update2018/ShortCircuitOperators_A03_t04 broke (Pass -> CompileTimeError, expected Pass)
co19_2/LanguageFeatures/Set-literals/constant_set_literals_A01_t01/none broke (Pass -> CompileTimeError, expected Pass)
co19_2/LanguageFeatures/Set-literals/constant_set_literals_A02_t02/none broke (Pass -> CompileTimeError, expected Pass)
co19_2/LanguageFeatures/Set-literals/constant_set_literals_A02_t03/none broke (Pass -> CompileTimeError, expected Pass)
co19_2/LanguageFeatures/Set-literals/constant_set_literals_A05_t01/none broke (Pass -> CompileTimeError, expected Pass)

co19_2/LanguageFeatures/Set-literals/exact_types_of_literals_A01_t01/none broke (Pass -> CompileTimeError, expected Pass)
co19_2/LanguageFeatures/Set-literals/exact_types_of_literals_A01_t02/none broke (Pass -> CompileTimeError, expected Pass)
co19_2/LanguageFeatures/Set-literals/semantics_A01_t01/none broke (Pass -> CompileTimeError, expected Pass)
co19_2/LanguageFeatures/Set-literals/semantics_A02_t01/none broke (Pass -> CompileTimeError, expected Pass)
co19_2/LanguageFeatures/Set-literals/semantics_A03_t01/none broke (Pass -> CompileTimeError, expected Pass)
co19_2/LanguageFeatures/Set-literals/semantics_A05_t02 failed again (RuntimeError -> CompileTimeError, expected Pass)
co19_2/LanguageFeatures/Set-literals/semantics_A05_t03 broke (Pass -> CompileTimeError, expected Pass)
co19_2/LanguageFeatures/Set-literals/semantics_A05_t04 broke (Pass -> CompileTimeError, expected Pass)
co19_2/LanguageFeatures/Set-literals/semantics_A05_t05/none broke (Pass -> CompileTimeError, expected Pass)
co19_2/LanguageFeatures/Set-literals/set_literals_A01_t02/none broke (Pass -> CompileTimeError, expected Pass)
co19_2/LanguageFeatures/Set-literals/set_literals_A03_t01/none broke (Pass -> CompileTimeError, expected Pass)
co19_2/LanguageFeatures/Set-literals/set_literals_A03_t02/none broke (Pass -> CompileTimeError, expected Pass)
co19_2/LanguageFeatures/Set-literals/set_literals_A04_t02/none broke (Pass -> CompileTimeError, expected Pass)

@whesse whesse added the area-dart2js label Jan 9, 2019

@whesse whesse added this to the Dart2.2 milestone Jan 9, 2019

@sigmundch

This comment has been minimized.

Copy link
Member

sigmundch commented Jan 11, 2019

Thanks - We are now accepting the flag. Set-literals are working, constants have not been integrated, but that's tracked elsewhere. I just landed a change updating some of the expectations and we will be looking more closely to what remains.

@sigmundch sigmundch closed this Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment