Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve modular compilation pipeline with kernel #36224

Open
jakemac53 opened this Issue Mar 14, 2019 · 4 comments

Comments

Projects
None yet
3 participants
@jakemac53
Copy link
Contributor

jakemac53 commented Mar 14, 2019

The general idea here is to create a new initializeModularCompiler which can re-use Components from previous compiles (based on an input digest which we provide through the bazel worker protocol).

We should hide this behind a flag as well so we can roll it out safely.

cc @jensjoha

@jakemac53 jakemac53 added this to the Dart2.3 milestone Mar 14, 2019

@jakemac53

This comment has been minimized.

Copy link
Contributor Author

jakemac53 commented Mar 15, 2019

Note that we also need to resolve the issues around config specific imports still - but I think the pending change from @sigmundch might give us all we need (ability to provide a custom libraries.json)

@jakemac53

This comment has been minimized.

Copy link
Contributor Author

jakemac53 commented Mar 15, 2019

https://dart-review.googlesource.com/c/sdk/+/97003 gets things compiling with configurable imports, although I am having some runtime failures now when using the test package (couldn't compile it at all before though, so that is a step forward).

@vsmenon

This comment has been minimized.

Copy link
Member

vsmenon commented Mar 19, 2019

@jensjoha @kmillikin @jakemac53 - do we know what's needed here?

@vsmenon

This comment has been minimized.

Copy link
Member

vsmenon commented Mar 25, 2019

Any ETA on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.