Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding policy for "breaking" changes to hints/lints #41530

Open
davidmorgan opened this issue Apr 16, 2020 · 4 comments
Open

Consider adding policy for "breaking" changes to hints/lints #41530

davidmorgan opened this issue Apr 16, 2020 · 4 comments
Labels
area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). type-question A question about expected behavior or functionality

Comments

@davidmorgan
Copy link
Contributor

In theory hint/lint changes are not breaking, but in practice they are, since checking analyzer output is a standard part of builds / travis checks. (google3, flutter, ...)

We should figure out if it's okay for an SDK release to turn travis builds red for hints/lints, or if these should count as breaking changes, or if there is a good middle ground.

@bwilkerson
Copy link
Member

@pq FYI

@pq
Copy link
Member

pq commented Apr 16, 2020

See also: dart-lang/linter#1225.

I agree that what we're doing is a little Wild West and some guidance would be good. How would we treat rolls differently if we characterized, for example, tightened lints (such as the recent change to flag type names in catch clauses) as breaking?

Thanks for kicking this off!

@pq
Copy link
Member

pq commented Apr 16, 2020

Popping up, regardless of what a breaking policy would say, it would be great if we had a better process for vetting lint and analysis changes in the SDK. I'll follow-up offline with ideas on that.

@devoncarew devoncarew added area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). type-question A question about expected behavior or functionality labels Apr 17, 2020
@srawlins
Copy link
Member

I documented a proposal a while ago at dart-lang/linter#1225. We should probably just have a proper document in the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). type-question A question about expected behavior or functionality
Projects
None yet
Development

No branches or pull requests

5 participants