Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Huge regression in IsolateJson benchmark #41962

Open
askeksa-google opened this issue May 19, 2020 · 0 comments
Open

Huge regression in IsolateJson benchmark #41962

askeksa-google opened this issue May 19, 2020 · 0 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. type-performance Issue relates to performance or code size

Comments

@askeksa-google
Copy link

The change to write UTF-8 decoded characters directly into the result strings resulted in a 8x-20x slowdown of the IsolateJson.Decode* benchmarks on ARMv8.

It looks like the central decode16 method is compiled through OSR for every call to it (200 calls in total when running all of those benchmarks). Deoptimization tracing indicates that the method is never deoptimized.

@askeksa-google askeksa-google added area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. type-performance Issue relates to performance or code size labels May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. type-performance Issue relates to performance or code size
Projects
None yet
Development

No branches or pull requests

1 participant