Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failures on Migrator: Check dependencies with pub outdated #42049

Closed
sstrickl opened this issue May 26, 2020 · 4 comments
Closed

Failures on Migrator: Check dependencies with pub outdated #42049

sstrickl opened this issue May 26, 2020 · 4 comments
Assignees
Labels
area-migration (deprecated) Deprecated: this label is no longer actively used (was: issues with the `dart migrate` tool). gardening

Comments

@sstrickl
Copy link
Contributor

There are new test failures on Migrator: Check dependencies with pub outdated.

The tests

pkg/dartdev/test/commands/migrate_test RuntimeError (expected Pass)

are failing on configurations

unittest-asserts-release-win

Assigning to @srawlins and temporarily approving for now.

@sstrickl sstrickl added area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. gardening labels May 26, 2020
@srawlins
Copy link
Member

Hi @sstrickl how do I see these new failures?

@sstrickl
Copy link
Contributor Author

Sorry. The log for the failure is here. The results feed that show newly passing/failing tests per build (with links to logs by hovering over failing tests) is here for future use. :)

@srawlins srawlins added analyzer-nnbd-migration area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. and removed area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. labels May 27, 2020
@athomas
Copy link
Member

athomas commented May 28, 2020

I commented on the CL that landed the tests. I believe the root cause for the windows failures is the the tests assumed the executable is called pub on all platforms but it is pub.bat on Windows.

My comment is visible here:
https://dart-review.googlesource.com/c/sdk/+/148789/3/pkg/nnbd_migration/lib/migration_cli.dart

@srawlins srawlins reopened this May 28, 2020
@srawlins
Copy link
Member

I've filed #42102.

@stereotype441 stereotype441 added area-migration (deprecated) Deprecated: this label is no longer actively used (was: issues with the `dart migrate` tool). and removed analyzer-nnbd-migration area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. labels Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-migration (deprecated) Deprecated: this label is no longer actively used (was: issues with the `dart migrate` tool). gardening
Projects
None yet
Development

No branches or pull requests

4 participants