Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddc: Implement non-null assertions in NNBD weak mode #42404

Closed
alexmarkov opened this issue Jun 18, 2020 · 1 comment
Closed

ddc: Implement non-null assertions in NNBD weak mode #42404

alexmarkov opened this issue Jun 18, 2020 · 1 comment
Assignees
@nshahan
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. NNBD Issues related to NNBD Release web-dev-compiler
Projects
Dart web null safety

Comments

@alexmarkov
Copy link
Contributor

There are new test failures on [vm/nnbd] Non-null assertions in NNBD weak mode. That CL adds test for null assertions in NNBD weak mode which now fails on DDC.

The test

language/nnbd/null_assertions/parameter_checks_test RuntimeError (expected Pass)

is failing on configuration

dartdevk-weak-linux-release-chrome

@sigmundch @nshahan
@alexmarkov alexmarkov added web-dev-compiler area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. NNBD Issues related to NNBD Release labels Jun 18, 2020
@nshahan
Copy link
Contributor

nshahan commented Jun 18, 2020

Thanks for adding tests! I'll work on converting our warning messages to assertions.

@nshahan nshahan self-assigned this Jun 18, 2020
@sigmundch sigmundch changed the title Failures on "[vm/nnbd] Non-null assertions in NNBD weak mode" in DDC ddc: Implement non-null assertions in NNBD weak mode Jun 29, 2020
Dart web null safety automation moved this from beta to done Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nshahan nshahan

Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. NNBD Issues related to NNBD Release web-dev-compiler
Projects
Dart web null safety
  
done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nshahan @alexmarkov