Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make "languageVersion" in EmbedderSdk constructor required #42890

Open
scheglov opened this issue Jul 31, 2020 · 0 comments
Open

Make "languageVersion" in EmbedderSdk constructor required #42890

scheglov opened this issue Jul 31, 2020 · 0 comments
Assignees
@scheglov
Labels
analyzer-technical-debt area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. contributions-welcome Contributions welcome to help resolve this (the resolution is expected to be clear from the issue) P3 A lower priority bug or feature request type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable

Comments

@scheglov
Copy link
Contributor

dartdoc creates EmbedderSdk, so we cannot just make it required right now, we need first update dartdoc to provide it. Or use a much slower API in dartdoc.
@scheglov scheglov added area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. analyzer-technical-debt labels Jul 31, 2020
@scheglov scheglov self-assigned this Jul 31, 2020
@srawlins srawlins added the P3 A lower priority bug or feature request label Dec 2, 2020
@srawlins srawlins added the type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable label Dec 1, 2021
@srawlins srawlins added the contributions-welcome Contributions welcome to help resolve this (the resolution is expected to be clear from the issue) label May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scheglov scheglov

Labels
analyzer-technical-debt area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. contributions-welcome Contributions welcome to help resolve this (the resolution is expected to be clear from the issue) P3 A lower priority bug or feature request type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@srawlins @scheglov