Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dartdevk DateTime constructor issue #42894

Closed
sgrekhov opened this issue Jul 31, 2020 · 3 comments
Closed

dartdevk DateTime constructor issue #42894

sgrekhov opened this issue Jul 31, 2020 · 3 comments
Assignees
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. web-dev-compiler

Comments

@sgrekhov
Copy link
Contributor

The following test fails on dartdevk

Expect.equals(new DateTime(1, 0, 1, 0, 0, 0, 0), new DateTime(0, 12, 1, 0, 0, 0, 0));

dartdevk output is

Runtime error:
Error: Expect.equals(expected: <0001-12-01 00:00:00.000>, actual: <0000-12-01 00:00:00.000>) fails.

On all other platforms this test works as expected

@nshahan nshahan added area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. web-dev-compiler labels Jul 31, 2020
@sigmundch
Copy link
Member

Note: this works in dart2js, so I'm guessing we fixed this in the dart2js patch files (1, 2) but not on the ddc patch files (3, 4)

@rileyporter rileyporter self-assigned this Sep 25, 2020
@rileyporter
Copy link
Contributor

Broke existing screenshot tests from various teams. In order to unblock roll, might be reverted in https://dart-review.googlesource.com/c/sdk/+/164786 and then resubmitted with screenshot test updates.

@rileyporter
Copy link
Contributor

The roll team decided to update the screenshots instead of revert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. web-dev-compiler
Projects
None yet
Development

No branches or pull requests

4 participants