Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception computing bulk fixes for parts (running dart fix) #43564

Closed
pq opened this issue Sep 25, 2020 · 0 comments
Closed

Exception computing bulk fixes for parts (running dart fix) #43564

pq opened this issue Sep 25, 2020 · 0 comments
Assignees
Labels
area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. dart-cli-fix

Comments

@pq
Copy link
Member

pq commented Sep 25, 2020

Exception:

Computing fixes in analyzer...
Error from the analysis server: Exception while getting bulk fixes: Invalid argument(s): Is a part: /Users/pquitslund/src/repos/dart/sdk/pkg/analyzer/lib/src/generated/parser_fasta.dart
#0      AnalysisDriver.getResolvedLibrary (package:analyzer/src/dart/analysis/driver.dart:721:7)
#1      AnalysisSessionImpl.getResolvedLibrary (package:analyzer/src/dart/analysis/session.dart:107:20)
#2      BulkFixProcessor.fixErrorsInLibraries (package:analysis_server/src/services/correction/bulk_fix_processor.dart:150:41)
<asynchronous suspension>
#3      EditDomainHandler.bulkFixes (package:analysis_server/src/edit/edit_domain.dart:116:43)
#4      EditDomainHandler.handleRequest (package:analysis_server/src/edit/edit_domain.dart:397:9)
#5      AnalysisServer.handleRequest.<anonymous closure> (package:analysis_server/src/analysis_server.dart:239:38)
#6      _rootRun (dart:async/zone.dart:1190:13)
#7      _CustomZone.run (dart:async/zone.dart:1093:19)
#8      _runZoned (dart:async/zone.dart:1630:10)
#9      runZonedGuarded (dart:async/zone.dart:1618:12)
#10     AnalysisServer.handleRequest (package:analysis_server/src/analysis_server.dart:235:5)
#11     ByteStreamServerChannel._readRequest (package:analysis_server/src/channel/byte_stream_channel.dart:163:14)
#12     ByteStreamServerChannel.listen.<anonymous closure> (package:analysis_server/src/channel/byte_stream_channel.dart:103:26)
#13     _rootRunUnary (dart:async/zone.dart:1198:47)
#14     _CustomZone.runUnary (dart:async/zone.dart:1100:19)
#15     _CustomZone.runUnaryGuarded (dart:async/zone.dart:1005:7)
#16     _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:357:11)
#17     _BufferingStreamSubscription._add (dart:async/stream_impl.dart:285:7)
#18     _SinkTransformerStreamSubscription._add (dart:async/stream_transformers.dart:69:11)
#19     _EventSinkWrapper.add (dart:async/stream_transformers.dart:15:11)
#20     _StringAdapterSink.add (dart:convert/string_conversion.dart:238:11)
#21     _LineSplitterSink._addLines (dart:convert/line_splitter.dart:155:13)
#22     _LineSplitterSink.addSlice (dart:convert/line_splitter.dart:130:5)
#23     StringConversionSinkMixin.add (dart:convert/string_conversion.dart:163:5)
#24     _SinkTransformerStreamSubscription._handleData (dart:async/stream_transformers.dart:121:24)
#25     _rootRunUnary (dart:async/zone.dart:1198:47)
#26     _CustomZone.runUnary (dart:async/zone.dart:1100:19)
#27     _CustomZone.runUnaryGuarded (dart:async/zone.dart:1005:7)
#28     _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:357:11)
#29     _BufferingStreamSubscription._add (dart:async/stream_impl.dart:285:7)
#30     _SinkTransformerStreamSubscription._add (dart:async/stream_transformers.dart:69:11)
#31     _EventSinkWrapper.add (dart:async/stream_transformers.dart:15:11)
#32     _StringAdapterSink.add (dart:convert/string_conversion.dart:238:11)
#33     _StringAdapterSink.addSlice (dart:convert/string_conversion.dart:243:7)
#34     _Utf8ConversionSink.addSlice (dart:convert/string_conversion.dart:317:20)
#35     _Utf8ConversionSink.add (dart:convert/string_conversion.dart:310:5)
#36     _ConverterStreamEventSink.add (dart:convert/chunked_conversion.dart:72:18)
#37     _SinkTransformerStreamSubscription._handleData (dart:async/stream_transformers.dart:121:24)
#38     _rootRunUnary (dart:async/zone.dart:1198:47)
#39     _CustomZone.runUnary (dart:async/zone.dart:1100:19)
#40     _CustomZone.runUnaryGuarded (dart:async/zone.dart:1005:7)
#41     _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:357:11)
#42     _BufferingStreamSubscription._add (dart:async/stream_impl.dart:285:7)
#43     _SyncStreamControllerDispatch._sendData (dart:async/stream_controller.dart:808:19)
#44     _StreamController._add (dart:async/stream_controller.dart:682:7)
#45     _StreamController.add (dart:async/stream_controller.dart:624:5)
#46     _Socket._onData (dart:io-patch/socket_patch.dart:1969:41)
#47     _rootRunUnary (dart:async/zone.dart:1206:13)
#48     _CustomZone.runUnary (dart:async/zone.dart:1100:19)
#49     _CustomZone.runUnaryGuarded (dart:async/zone.dart:1005:7)
#50     _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:357:11)
#51     _BufferingStreamSubscription._add (dart:async/stream_impl.dart:285:7)
#52     _SyncStreamControllerDispatch._sendData (dart:async/stream_controller.dart:808:19)
#53     _StreamController._add (dart:async/stream_controller.dart:682:7)
#54     _StreamController.add (dart:async/stream_controller.dart:624:5)
#55     new _RawSocket.<anonymous closure> (dart:io-patch/socket_patch.dart:1505:33)
#56     _NativeSocket.issueReadEvent.issue (dart:io-patch/socket_patch.dart:1017:14)
#57     _microtaskLoop (dart:async/schedule_microtask.dart:41:21)
#58     _startMicrotaskLoop (dart:async/schedule_microtask.dart:50:5)
#59     _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:118:13)
#60     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:169:5)


To reproduce.

Enable the following lints in analyzer/analysis_options.yaml:

    - annotate_overrides
    - avoid_annotating_with_dynamic
    - avoid_empty_else
    - avoid_init_to_null
    - avoid_redundant_argument_values
    - avoid_return_types_on_setters
    - avoid_single_cascade_in_expression_statements
    - avoid_types_on_closure_parameters
    - await_only_futures
    - curly_braces_in_flow_control_structures
    - diagnostic_describe_all_properties
    - empty_catches
    - empty_constructor_bodies
    - empty_statements
    - hash_and_equals
    - no_duplicate_case_values
    - non_constant_identifier_names
    - null_closures
    - omit_local_variable_types
    - prefer_adjacent_string_concatenation
    - prefer_collection_literals
    - prefer_conditional_assignment
    - prefer_const_constructors_in_immutables
    - prefer_const_declarations
    - prefer_contains
    - prefer_equal_for_default_values
    - prefer_final_fields
    - prefer_final_locals
    - prefer_for_elements_to_map_fromIterable
    - prefer_generic_function_type_aliases
    - prefer_if_elements_to_conditional_expressions
    - prefer_if_null_operators
    - prefer_int_literals
    - prefer_is_empty
    - prefer_is_not_empty
    - prefer_iterable_whereType
    - prefer_null_aware_operators
    - prefer_relative_imports
    - prefer_single_quotes
    - prefer_spread_collections
    - slash_for_doc_comments
    - sort_child_properties_last
    - type_init_formals
    - unawaited_futures
    - unnecessary_brace_in_string_interps
    - unnecessary_const
    - unnecessary_lambdas
    - unnecessary_new
    - unnecessary_overrides
    - unnecessary_this
    - use_rethrow_when_possible

then run dart fix:

[~/src/repos/dart/sdk/pkg/analyzer] $ dart ../dartdev/bin/dartdev.dart fix

/cc @bwilkerson

@pq pq added area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. and removed area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. labels Sep 25, 2020
@pq pq changed the title Exception computing bulk fixes for parts Exception computing bulk fixes for parts (running dart fix) Sep 25, 2020
@pq pq added area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. dart-cli-fix and removed area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. labels Sep 25, 2020
@pq pq self-assigned this Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. dart-cli-fix
Projects
None yet
Development

No branches or pull requests

1 participant