Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP][stable channel] revert previous cherry-pick for DDC #43661

Closed
sigmundch opened this issue Oct 2, 2020 · 5 comments
Closed

[CP][stable channel] revert previous cherry-pick for DDC #43661

sigmundch opened this issue Oct 2, 2020 · 5 comments
Assignees
@athomas
Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve merge-to-stable

Comments

@sigmundch
Copy link
Member

sigmundch commented Oct 2, 2020 •
edited by athomas
Loading

commit(s) to merge: 350481a (https://dart-review.googlesource.com/c/sdk/+/165873 in the CQ, which reverts 53895b2)

merge instructions: expect a clean merge

What is the issue: A fix of a previous issue that we cherry-picked introduced additional problems.

What is the fix: Revert the previous cherry-pick (#43453) and work on an alternative solution to the original problem.

Why cherrypick: We think removing the old cherry-pick is a safer path forward.

The bug in question has existed for years, only recently a flutter package with unique code-generation patterns triggered the bug (flutter/flutter#64011). The fix revealed new failures like (flutter/flutter#66859) that affect simpler packages and we are afraid the scope of the failures could potentially be a lot wider. To prevent further regressions and disruptions, we prefer to remove the earlier "fix" until we find a proper solution.

Risk: Low, this brings the behavior back to what it was before.

Link to original issue(s):
flutter/flutter#64011 - the original problem
flutter/flutter#66859 - an example new problem from the earlier fix

The intent is to include this in the next 2.10.0 stable hotfix release

/cc @kevmoo @mit-mit @whesse @athomas @vsmenon @franklinyow @Markzipan
@sigmundch sigmundch added merge-to-stable cherry-pick-review Issue that need cherry pick triage to approve labels Oct 2, 2020
@franklinyow
Copy link
Contributor

Is this a revert of #43453 ?
@sigmundch Please fix the title. I can approve this after the CL merged

@sigmundch sigmundch changed the title [CP][stable channel] Please add descriptive title for the pick here [CP][stable channel] revert previous cherry-pick for DDC Oct 3, 2020
@sigmundch
Copy link
Member Author

Precisely.

Sorry I missed the title, I just updated it.

@mit-mit mit-mit added the area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. label Oct 5, 2020
@vsmenon
Copy link
Member

vsmenon commented Oct 5, 2020

lgtm

@franklinyow franklinyow added the cherry-pick-approved Label for approved cherrypick request label Oct 6, 2020
@franklinyow
Copy link
Contributor

Approved

@sigmundch sigmundch mentioned this issue Oct 7, 2020
Closed
@franklinyow
Copy link
Contributor

close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@athomas athomas

Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve merge-to-stable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@sigmundch @vsmenon @mit-mit @athomas @franklinyow