Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pkg/dev_compiler] dev_compiler unit tests failing with null safety enabled #43843

Closed
leafpetersen opened this issue Oct 19, 2020 · 9 comments
Closed

[pkg/dev_compiler] dev_compiler unit tests failing with null safety enabled #43843

leafpetersen opened this issue Oct 19, 2020 · 9 comments
Assignees
@nshahan
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. NNBD Issues related to NNBD Release P1 A high priority bug; for example, a single project is unusable or has many test failures web-dev-compiler

Comments

@leafpetersen
Copy link
Member

This CL tests out flipping on the experiment flag and bumping the SDK version. I see failures on pkg/dev_compiler unit tests here .

@sigmundch @nshahan can you triage and find the right person to look into this?
@leafpetersen leafpetersen added area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. NNBD Issues related to NNBD Release labels Oct 19, 2020
@leafpetersen
Copy link
Member Author

cc @munificent @franklinyow

@nshahan nshahan self-assigned this Oct 19, 2020
@nshahan
Copy link
Contributor

nshahan commented Oct 19, 2020

A fix is out for review to add the language version comment to some synthetic test files https://dart-review.googlesource.com/c/sdk/+/168441.

@leafpetersen
Copy link
Member Author

Thanks! I think I'm still seeing one failure though.

@leafpetersen leafpetersen reopened this Oct 20, 2020
@franklinyow franklinyow added the P1 A high priority bug; for example, a single project is unusable or has many test failures label Oct 20, 2020
@leafpetersen
Copy link
Member Author

Oddly, I now seem to be seeing failures on an expression_compiler test again, was there a regression? https://ci.chromium.org/p/dart/builders/try/pkg-linux-release-try/42881?

@leafpetersen leafpetersen reopened this Oct 21, 2020
@nshahan
Copy link
Contributor

nshahan commented Oct 21, 2020

😕

Strange, I'll take another look.

@nshahan
Copy link
Contributor

nshahan commented Oct 21, 2020

A few new test cases landed with source code that needs to be opted out. I'll update the test, hopefully the third time is a charm.

@leafpetersen
Copy link
Member Author

Thanks, confirmed no more failures!

@leafpetersen
Copy link
Member Author

The expression compiler test seems to have gone red again.

@leafpetersen leafpetersen reopened this Oct 27, 2020
@leafpetersen
Copy link
Member Author

Actually, no they haven't, apparently I can't read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nshahan nshahan

Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. NNBD Issues related to NNBD Release P1 A high priority bug; for example, a single project is unusable or has many test failures web-dev-compiler
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nshahan @leafpetersen @franklinyow